From 4f4d9c06355b64ae30e0c100be0ca55d01c16885 Mon Sep 17 00:00:00 2001 From: Matúš Kukan Date: Mon, 17 Mar 2014 11:36:31 +0100 Subject: Avoid duplicate symbols in libmerged for Windows too. This is working version of fc27a685d466dc380a8b68cd48f47db632ed3693 Change-Id: I48e861b5b7692ea051edf52d7ad9cc54ca989e22 --- idl/inc/database.hxx | 2 ++ idl/source/objects/types.cxx | 24 ++++++++++++++++++++++-- idl/source/prj/database.cxx | 1 + 3 files changed, 25 insertions(+), 2 deletions(-) (limited to 'idl') diff --git a/idl/inc/database.hxx b/idl/inc/database.hxx index 15e87f29da87..f9abfd226f4b 100644 --- a/idl/inc/database.hxx +++ b/idl/inc/database.hxx @@ -81,6 +81,8 @@ protected: aIFaceName = OString(); } public: + OUString sSlotMapFile; + explicit SvIdlDataBase( const SvCommand& rCmd ); ~SvIdlDataBase(); static sal_Bool IsBinaryFormat( SvStream & rInStm ); diff --git a/idl/source/objects/types.cxx b/idl/source/objects/types.cxx index 1797fa2b3409..265be88a2a21 100644 --- a/idl/source/objects/types.cxx +++ b/idl/source/objects/types.cxx @@ -1398,7 +1398,7 @@ sal_uLong SvMetaType::MakeSfx( OStringBuffer& rAttrArray ) } void SvMetaType::WriteSfxItem( - const OString& rItemName, SvIdlDataBase &, SvStream & rOutStm ) + const OString& rItemName, SvIdlDataBase& rBase, SvStream& rOutStm ) { WriteStars( rOutStm ); OStringBuffer aVarName(" a"); @@ -1411,14 +1411,34 @@ void SvMetaType::WriteSfxItem( OString::number(nAttrCount)); aTypeName.append(aAttrCount); - rOutStm.WriteCharPtr( "extern " ).WriteCharPtr( aTypeName.getStr() ) + bool bExport = false, bReturn = false; + // these are exported from sfx library + if (rItemName == "SfxBoolItem" || + rItemName == "SfxStringItem" || + rItemName == "SfxUInt16Item" || + rItemName == "SfxUInt32Item" || + rItemName == "SfxVoidItem") + { + bExport = true; + if (!rBase.sSlotMapFile.endsWith("sfxslots.hxx")) + bReturn = true; + } + + rOutStm.WriteCharPtr( "extern " ); + if (bExport) + rOutStm.WriteCharPtr( "SFX2_DLLPUBLIC " ); + rOutStm.WriteCharPtr( aTypeName.getStr() ) .WriteCharPtr( aVarName.getStr() ).WriteChar( ';' ) << endl; + if (bReturn) + return; // write the implementation part rOutStm.WriteCharPtr( "#ifdef SFX_TYPEMAP" ) << endl; rOutStm.WriteCharPtr( "#if !defined(_WIN32) && ((defined(DISABLE_DYNLOADING) && (defined(ANDROID) || defined(IOS))) || STATIC_LINKING)" ) << endl; rOutStm.WriteCharPtr( "__attribute__((__weak__))" ) << endl; rOutStm.WriteCharPtr( "#endif" ) << endl; + if (bExport) + rOutStm.WriteCharPtr( "SFX2_DLLPUBLIC " ); rOutStm.WriteCharPtr( aTypeName.getStr() ).WriteCharPtr( aVarName.getStr() ) .WriteCharPtr( " = " ) << endl; rOutStm.WriteChar( '{' ) << endl; diff --git a/idl/source/prj/database.cxx b/idl/source/prj/database.cxx index 3ac165ddcabe..04f351c6c80d 100644 --- a/idl/source/prj/database.cxx +++ b/idl/source/prj/database.cxx @@ -34,6 +34,7 @@ SvIdlDataBase::SvIdlDataBase( const SvCommand& rCmd ) , aPersStream( *IDLAPP->pClassMgr, NULL ) , pIdTable( NULL ) { + sSlotMapFile = rCmd.aSlotMapFile; } SvIdlDataBase::~SvIdlDataBase() -- cgit