From f8ecdb7619cad29a6187004e28075efd928bd8aa Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 6 Oct 2016 16:36:26 +0200 Subject: Simplify AstExpression::compare ...to only work with LONG values, as it is only used to compare enumerator values. (But keep its general defensive-programming air that's so prevalent across the idlc code base; not sure whether it could rightfully be tightened, or whether this might be needed in parser's error recovery.) Change-Id: I15f1700834f9397f3c2e0ffdb00e2abeecb734f9 --- idlc/inc/astexpression.hxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'idlc/inc') diff --git a/idlc/inc/astexpression.hxx b/idlc/inc/astexpression.hxx index ca060719ef2e..9bc1b9004409 100644 --- a/idlc/inc/astexpression.hxx +++ b/idlc/inc/astexpression.hxx @@ -114,8 +114,8 @@ public: // Evaluate then store value inside this AstExpression void evaluate(); - // Compare to AstExpressions - bool compare(AstExpression *pExpr); + // Compare LONG AstExpression values + bool compareLong(AstExpression *pExpr); OString toString(); private: -- cgit