From b14224fe97b8a44232c9c1401d3a49771f46582e Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 2 Feb 2016 16:15:51 +0200 Subject: loplugin:unusedmethods using an idea from dtardon: noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- include/comphelper/property.hxx | 22 ---------------------- include/comphelper/stl_types.hxx | 1 - include/comphelper/string.hxx | 19 ------------------- 3 files changed, 42 deletions(-) (limited to 'include/comphelper') diff --git a/include/comphelper/property.hxx b/include/comphelper/property.hxx index 5bc46a888d99..bad79df7f692 100644 --- a/include/comphelper/property.hxx +++ b/include/comphelper/property.hxx @@ -40,28 +40,6 @@ namespace comphelper } }; - struct PropertyStringEqualFunctor : ::std::binary_function< css::beans::Property, OUString, bool > - { - - inline bool operator()( const css::beans::Property& lhs, const OUString& rhs ) const - { - return lhs.Name == rhs ; - } - - inline bool operator()( const OUString& lhs, const css::beans::Property& rhs ) const - { - return lhs == rhs.Name ; - } - }; - - struct PropertyEqualByName : public ::std::binary_function< css::beans::Property, css::beans::Property, bool > - { - bool operator() (const css::beans::Property& x, const css::beans::Property& y) const - { - return x.Name == y.Name ; - } - }; - /// remove the property with the given name from the given sequence COMPHELPER_DLLPUBLIC void RemoveProperty(css::uno::Sequence& seqProps, const OUString& _rPropName); diff --git a/include/comphelper/stl_types.hxx b/include/comphelper/stl_types.hxx index f154937bd507..f38a9cf061a5 100644 --- a/include/comphelper/stl_types.hxx +++ b/include/comphelper/stl_types.hxx @@ -181,7 +181,6 @@ public: } Self & operator*() { return *this; } // so operator= works Self & operator++() { return *this; } - Self & operator++(int) { return *this; } private: OUStringBuffer & m_rBuffer; diff --git a/include/comphelper/string.hxx b/include/comphelper/string.hxx index 90b1e3e4384e..eb72beda89eb 100644 --- a/include/comphelper/string.hxx +++ b/include/comphelper/string.hxx @@ -38,16 +38,6 @@ // go into the stable URE API: namespace comphelper { namespace string { -/** Compare an OString to a single char - - @param rIn The input OString - @param c The character to compare againsg - - @return true if rIn has one char and its equal to c - */ -inline bool equals(const OString& rIn, sal_Char c) -{ return rIn.getLength() == 1 && rIn[0] == c; } - /** Compare an OUString to a single char @param rIn The input OUString @@ -399,15 +389,6 @@ COMPHELPER_DLLPUBLIC bool isdigitAsciiString(const OString &rString); */ COMPHELPER_DLLPUBLIC bool isdigitAsciiString(const OUString &rString); -/** Compare two strings containing software version numbers - - Inspired by the GNU strverscmp(), but there is no guarantee that the exact - same semantics are used, or that the semantics are stable between LibreOffice versions. - - @return -1, 0 or 1 -*/ -COMPHELPER_DLLPUBLIC int compareVersionStrings(const OUString& a, const OUString& b); - } } #endif -- cgit