From b14107dd0eaf9bfc276544e1900873d36075425e Mon Sep 17 00:00:00 2001 From: Dennis Francis Date: Wed, 6 Jan 2021 17:44:00 +0530 Subject: tdf#133858 reduce the double-ref range to data content MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit in certain matrix formulas like SUM(IF(A1=G:G, H:H)*B1/B2) where whole columns are used for comparison in the condition of IF ultimately followed by a reducer like SUM. In such cases we can safely reduce the double-refs involved in the comparison to the sheet area where there is data before converting the data to ScMatrix. This is a more restricted version of Noel's fix in 37ffe509ef011357123642577c04ff296d59ce68 Change-Id: I1c2e8985adedb3f4c4648f541fb0e8e7d0fae033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109050 Reviewed-by: Luboš Luňák Tested-by: Jenkins CollaboraOffice (cherry picked from commit 65167a9265acfea04733b5ff6ee3220a9da624f4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109118 Tested-by: Jenkins Reviewed-by: Dennis Francis --- include/formula/FormulaCompiler.hxx | 2 ++ 1 file changed, 2 insertions(+) (limited to 'include/formula/FormulaCompiler.hxx') diff --git a/include/formula/FormulaCompiler.hxx b/include/formula/FormulaCompiler.hxx index 9fdd5a521087..c455ca407d1d 100644 --- a/include/formula/FormulaCompiler.hxx +++ b/include/formula/FormulaCompiler.hxx @@ -334,6 +334,8 @@ protected: // Called from CompileTokenArray() after RPN code generation is done. virtual void PostProcessCode() {} + virtual void AnnotateOperands() {} + OUString aCorrectedFormula; // autocorrected Formula OUString aCorrectedSymbol; // autocorrected Symbol -- cgit