From 09cd0e363d6c5b0e7b9cebc598030a7e3d397922 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 23 Aug 2019 14:59:48 +0200 Subject: loplugin:returnconstval in oox Change-Id: Id83744fcb90d1bf6e6fe048858f48a4944351494 Reviewed-on: https://gerrit.libreoffice.org/78013 Tested-by: Jenkins Reviewed-by: Noel Grandin --- include/oox/core/xmlfilterbase.hxx | 2 +- include/oox/ole/axcontrol.hxx | 2 +- include/oox/ppt/pptimport.hxx | 2 +- include/oox/shape/ShapeFilterBase.hxx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'include/oox') diff --git a/include/oox/core/xmlfilterbase.hxx b/include/oox/core/xmlfilterbase.hxx index 4f828abf82eb..68bd801eaefd 100644 --- a/include/oox/core/xmlfilterbase.hxx +++ b/include/oox/core/xmlfilterbase.hxx @@ -102,7 +102,7 @@ public: virtual void useInternalChartDataTable( bool /*bInternal*/ ) { } /** Has to be implemented by each filter to return the table style list. */ - virtual const ::oox::drawingml::table::TableStyleListPtr getTableStyles() = 0; + virtual ::oox::drawingml::table::TableStyleListPtr getTableStyles() = 0; OUString getFragmentPathFromFirstTypeFromOfficeDoc( const OUString& rPart ); diff --git a/include/oox/ole/axcontrol.hxx b/include/oox/ole/axcontrol.hxx index 968360a5b39b..d1d47459bdb8 100644 --- a/include/oox/ole/axcontrol.hxx +++ b/include/oox/ole/axcontrol.hxx @@ -334,7 +334,7 @@ public: PropertySet const & rPropSet, sal_Int32& nOrientation ); - const css::uno::Reference GetDocModel() const { return mxDocModel; } + const css::uno::Reference & GetDocModel() const { return mxDocModel; } private: css::uno::Reference< css::frame::XModel > mxDocModel; diff --git a/include/oox/ppt/pptimport.hxx b/include/oox/ppt/pptimport.hxx index c97a6f8c4f57..c5ff1b1e5a0c 100644 --- a/include/oox/ppt/pptimport.hxx +++ b/include/oox/ppt/pptimport.hxx @@ -62,7 +62,7 @@ public: virtual const ::oox::drawingml::Theme* getCurrentTheme() const override; virtual ::oox::vml::Drawing* getVmlDrawing() override; - virtual const oox::drawingml::table::TableStyleListPtr getTableStyles() override; + virtual oox::drawingml::table::TableStyleListPtr getTableStyles() override; virtual ::oox::drawingml::chart::ChartConverter* getChartConverter() override; const SlidePersistPtr& getActualSlidePersist() const { return mpActualSlidePersist; }; diff --git a/include/oox/shape/ShapeFilterBase.hxx b/include/oox/shape/ShapeFilterBase.hxx index 50d80f39cae9..b0ddbff4e217 100644 --- a/include/oox/shape/ShapeFilterBase.hxx +++ b/include/oox/shape/ShapeFilterBase.hxx @@ -56,7 +56,7 @@ public: virtual ::oox::vml::Drawing* getVmlDrawing() override; /** Has to be implemented by each filter to return TableStyles. */ - virtual const ::oox::drawingml::table::TableStyleListPtr getTableStyles() override; + virtual ::oox::drawingml::table::TableStyleListPtr getTableStyles() override; virtual ::oox::drawingml::chart::ChartConverter* getChartConverter() override; -- cgit