From 82572caae4a282cdf79456b977508ca71507c584 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 18 Sep 2019 14:15:59 +0200 Subject: improve and enable loplugin:fragiledestructor Where the problem was benign and the class was not extended, I marked the class as final. Where the problem was benign and the class was extended, I marked the relevant callee methods as final. Other cases were excluded in the plugin. Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc Reviewed-on: https://gerrit.libreoffice.org/79089 Tested-by: Jenkins Reviewed-by: Noel Grandin --- include/oox/helper/binaryinputstream.hxx | 2 +- include/oox/helper/binaryoutputstream.hxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'include/oox') diff --git a/include/oox/helper/binaryinputstream.hxx b/include/oox/helper/binaryinputstream.hxx index 1174b0f61f2f..2e7f2e55012a 100644 --- a/include/oox/helper/binaryinputstream.hxx +++ b/include/oox/helper/binaryinputstream.hxx @@ -234,7 +234,7 @@ sal_Int32 BinaryInputStream::readArray( ::std::vector< Type >& orVector, sal_Int The binary data in the stream is assumed to be in little-endian format. */ -class OOX_DLLPUBLIC BinaryXInputStream : public BinaryXSeekableStream, public BinaryInputStream +class OOX_DLLPUBLIC BinaryXInputStream final : public BinaryXSeekableStream, public BinaryInputStream { public: /** Constructs the wrapper object for the passed input stream. diff --git a/include/oox/helper/binaryoutputstream.hxx b/include/oox/helper/binaryoutputstream.hxx index 7041131d81e3..7f7cea6a2115 100644 --- a/include/oox/helper/binaryoutputstream.hxx +++ b/include/oox/helper/binaryoutputstream.hxx @@ -125,7 +125,7 @@ void BinaryOutputStream::writeValue( Type nValue ) The binary data in the stream is written in little-endian format. */ -class OOX_DLLPUBLIC BinaryXOutputStream : public BinaryXSeekableStream, public BinaryOutputStream +class OOX_DLLPUBLIC BinaryXOutputStream final : public BinaryXSeekableStream, public BinaryOutputStream { public: /** Constructs the wrapper object for the passed output stream. -- cgit