From fb0ca7eff0e16fa8dd1a4c8d75fef23830903a3f Mon Sep 17 00:00:00 2001 From: Andrzej Hunt Date: Mon, 5 May 2014 20:48:58 +0100 Subject: fdo#76261 Get rid of unneeded and malfunctioning maItemListRect. maItemListRect serves as a sort of bounding box for what items /could/ be visible on screen, however it is only used for determining the id of an item we have just clicked on -- given that we already know that we are clicking inside the visible area this is an unnecessary check. In fact this check is erronous as we no longer limit ourselves to "whole" rows as of 806919adf9c9bafbaba92c2d2ab35d2e2f9863f8 -- i.e. the previous assumption was that a view large enough for n rows will show precisely n (whole) rows, whereas we might be showing (n-1) complete rows, and a fraction of a row at the top and bottom of the screen, i.e. a total of n+1 rows, where maItemRect only encloses the top n rows, meaning we were erronously ignoring clicks on the (partly visible) lowest n+1 row. Change-Id: Ia52ed2e0d217a9f077cef86ee9c1847252844995 --- include/sfx2/thumbnailview.hxx | 1 - 1 file changed, 1 deletion(-) (limited to 'include/sfx2') diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx index b7604266b4fd..31faaf7c40b0 100644 --- a/include/sfx2/thumbnailview.hxx +++ b/include/sfx2/thumbnailview.hxx @@ -309,7 +309,6 @@ protected: ThumbnailValueItemList mFilteredItemList; ///< Cache to store the filtered items ThumbnailValueItemList::iterator mpStartSelRange; ScrollBar* mpScrBar; - Rectangle maItemListRect; long mnHeaderHeight; long mnItemWidth; long mnItemHeight; -- cgit