From e3077168072452fb8f1c0a8afb2992877cb96d1c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 17 Jun 2021 09:49:37 +0200 Subject: loplugin:finalclasses improve the plugin to detect more cases. I only apply the new final changes to classes in /include here. Which reveals that RoadmapWizard::getPageController( TabPage* _pCurrentPage ) will always return nullptr Also needed to sprinkle some SAL_DLLPUBLIC_TEMPLATE around to workaround Visual Studio linking problems. Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365 Tested-by: Jenkins Reviewed-by: Noel Grandin --- include/sot/storage.hxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'include/sot/storage.hxx') diff --git a/include/sot/storage.hxx b/include/sot/storage.hxx index 41b57506946c..dd44b020694a 100644 --- a/include/sot/storage.hxx +++ b/include/sot/storage.hxx @@ -70,7 +70,7 @@ public: }; class BaseStorage; -class SOT_DLLPUBLIC SotStorage : virtual public SotObject +class SOT_DLLPUBLIC SotStorage final : virtual public SotObject { friend class SotStorageStream; @@ -83,7 +83,6 @@ friend class SotStorageStream; OString m_aKey; // aKey.Len != 0 -> encryption sal_Int32 m_nVersion; -protected: virtual ~SotStorage() override; void CreateStorage(bool bUCBStorage, StreamMode); public: -- cgit