From 3341435d7916c209c7613d594f78059ba112495b Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 25 May 2018 14:08:33 +0200 Subject: loplugin:passstuffbyref MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit ff3bdde2527123fc9e011ff0d93e958174632186) Reviewed-on: https://gerrit.libreoffice.org/54914 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- include/basegfx/polygon/b3dpolygon.hxx | 8 ++++---- include/basegfx/polygon/b3dpolypolygon.hxx | 2 +- include/filter/msfilter/svdfppt.hxx | 4 ++-- include/sfx2/charwin.hxx | 4 ++-- include/sfx2/opengrf.hxx | 2 +- include/svl/aeitem.hxx | 2 +- include/svx/charmap.hxx | 2 +- include/vcl/customweld.hxx | 2 +- 8 files changed, 13 insertions(+), 13 deletions(-) (limited to 'include') diff --git a/include/basegfx/polygon/b3dpolygon.hxx b/include/basegfx/polygon/b3dpolygon.hxx index 1d3dd515b757..47eefd498597 100644 --- a/include/basegfx/polygon/b3dpolygon.hxx +++ b/include/basegfx/polygon/b3dpolygon.hxx @@ -66,28 +66,28 @@ namespace basegfx sal_uInt32 count() const; // Coordinate interface - B3DPoint getB3DPoint(sal_uInt32 nIndex) const; + B3DPoint const & getB3DPoint(sal_uInt32 nIndex) const; void setB3DPoint(sal_uInt32 nIndex, const B3DPoint& rValue); // Coordinate append void append(const B3DPoint& rPoint, sal_uInt32 nCount = 1); // BColor interface - BColor getBColor(sal_uInt32 nIndex) const; + BColor const & getBColor(sal_uInt32 nIndex) const; void setBColor(sal_uInt32 nIndex, const BColor& rValue); bool areBColorsUsed() const; void clearBColors(); // Normals interface B3DVector const & getNormal() const; // plane normal - B3DVector getNormal(sal_uInt32 nIndex) const; // normal in each point + B3DVector const & getNormal(sal_uInt32 nIndex) const; // normal in each point void setNormal(sal_uInt32 nIndex, const B3DVector& rValue); void transformNormals(const B3DHomMatrix& rMatrix); bool areNormalsUsed() const; void clearNormals(); // TextureCoordinate interface - B2DPoint getTextureCoordinate(sal_uInt32 nIndex) const; + B2DPoint const & getTextureCoordinate(sal_uInt32 nIndex) const; void setTextureCoordinate(sal_uInt32 nIndex, const B2DPoint& rValue); void transformTextureCoordinates(const B2DHomMatrix& rMatrix); bool areTextureCoordinatesUsed() const; diff --git a/include/basegfx/polygon/b3dpolypolygon.hxx b/include/basegfx/polygon/b3dpolypolygon.hxx index ebab91a44ce2..ce659148c72a 100644 --- a/include/basegfx/polygon/b3dpolypolygon.hxx +++ b/include/basegfx/polygon/b3dpolypolygon.hxx @@ -62,7 +62,7 @@ namespace basegfx sal_uInt32 count() const; // B3DPolygon interface - B3DPolygon getB3DPolygon(sal_uInt32 nIndex) const; + B3DPolygon const & getB3DPolygon(sal_uInt32 nIndex) const; void setB3DPolygon(sal_uInt32 nIndex, const B3DPolygon& rPolygon); // BColor interface diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx index 7dc6082fb931..e3be8307a185 100644 --- a/include/filter/msfilter/svdfppt.hxx +++ b/include/filter/msfilter/svdfppt.hxx @@ -195,8 +195,8 @@ struct MSFILTER_DLLPUBLIC PptDocumentAtom public: - Size GetSlidesPageSize() const { return aSlidesPageSize; } - Size GetNotesPageSize() const { return aNotesPageSize; } + Size const & GetSlidesPageSize() const { return aSlidesPageSize; } + Size const & GetNotesPageSize() const { return aNotesPageSize; } friend SvStream& ReadPptDocumentAtom( SvStream& rIn, PptDocumentAtom& rAtom ); }; diff --git a/include/sfx2/charwin.hxx b/include/sfx2/charwin.hxx index 85c40d84b225..c718815b9bd2 100644 --- a/include/sfx2/charwin.hxx +++ b/include/sfx2/charwin.hxx @@ -50,9 +50,9 @@ public: SvxCharView(const VclPtr& rVirDev); void SetFont( const vcl::Font& rFont ); - vcl::Font GetFont() const { return maFont; } + vcl::Font const & GetFont() const { return maFont; } void SetText( const OUString& rText ); - OUString GetText() const { return m_sText; } + OUString const & GetText() const { return m_sText; } void SetHasInsert( bool bInsert ); void InsertCharToDoc(); diff --git a/include/sfx2/opengrf.hxx b/include/sfx2/opengrf.hxx index 0178cc0bb745..c99433a2c3f0 100644 --- a/include/sfx2/opengrf.hxx +++ b/include/sfx2/opengrf.hxx @@ -55,7 +55,7 @@ public: OUString const & GetDetectedFilter() const; void SetDetectedFilter(const OUString&); - css::uno::Reference GetFilePickerControlAccess(); + css::uno::Reference const & GetFilePickerControlAccess(); private: SvxOpenGraphicDialog (const SvxOpenGraphicDialog&) = delete; diff --git a/include/svl/aeitem.hxx b/include/svl/aeitem.hxx index add7e0b2c465..7be7e83352fd 100644 --- a/include/svl/aeitem.hxx +++ b/include/svl/aeitem.hxx @@ -61,7 +61,7 @@ public: virtual sal_uInt16 GetValueCount() const override; sal_uInt16 GetValueByPos( sal_uInt16 nPos ) const; - OUString GetValueTextByPos( sal_uInt16 nPos ) const; + OUString const & GetValueTextByPos( sal_uInt16 nPos ) const; virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; virtual SfxPoolItem* Create(SvStream &, sal_uInt16 nVersion) const override; }; diff --git a/include/svx/charmap.hxx b/include/svx/charmap.hxx index 2446c0607cbb..6e18581c4786 100644 --- a/include/svx/charmap.hxx +++ b/include/svx/charmap.hxx @@ -80,7 +80,7 @@ public: void SetFavClickHdl( const Link& rHdl ) { aFavClickHdl = rHdl; } static sal_uInt32& getSelectedChar(); void SetFont( const vcl::Font& rFont ); - vcl::Font GetFont() const { return mxVirDev->GetFont(); } + vcl::Font const & GetFont() const { return mxVirDev->GetFont(); } bool GetFontCharMap(FontCharMapRef& rxFontCharMap) const { return mxVirDev->GetFontCharMap(rxFontCharMap); } bool isFavChar(const OUString& sTitle, const OUString& rFont); void getFavCharacterList(); //gets both Fav char and Fav char font list diff --git a/include/vcl/customweld.hxx b/include/vcl/customweld.hxx index 4eef04e85323..274db81bd781 100644 --- a/include/vcl/customweld.hxx +++ b/include/vcl/customweld.hxx @@ -36,7 +36,7 @@ public: } virtual tools::Rectangle GetFocusRect() { return tools::Rectangle(); } virtual FactoryFunction GetUITestFactory() const { return nullptr; } - Size GetOutputSizePixel() const { return m_aSize; } + Size const& GetOutputSizePixel() const { return m_aSize; } void SetOutputSizePixel(const Size& rSize) { m_aSize = rSize; } virtual void SetDrawingArea(weld::DrawingArea* pDrawingArea) { m_pDrawingArea = pDrawingArea; } weld::DrawingArea* GetDrawingArea() const { return m_pDrawingArea; } -- cgit