From 552ceeb5c6ccf2573adfd092cc4b2ce214a9c2df Mon Sep 17 00:00:00 2001 From: "Armin Le Grand (Allotropia)" Date: Thu, 10 Jun 2021 19:24:04 +0200 Subject: tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN FontworkBar::getState does not need to check for SfxItemState::UNKNOWN at all, actions solely depend on FontWork object being selected. This also greatly simplifies that method. Also, the optimization by passing in a variable to checkForSelectedFontWork and remember if already computed can be removed - also in other places where it had to be given, but was not re-used at all Change-Id: I35b1f36195feb1d645619665d2dd65a84b75b118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117014 Tested-by: Jenkins Reviewed-by: Noel Grandin Reviewed-by: Armin Le Grand --- include/svx/fontworkbar.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include') diff --git a/include/svx/fontworkbar.hxx b/include/svx/fontworkbar.hxx index 33c67e8f051b..67c34c05e560 100644 --- a/include/svx/fontworkbar.hxx +++ b/include/svx/fontworkbar.hxx @@ -32,7 +32,7 @@ class SdrObject; namespace svx { -bool SVXCORE_DLLPUBLIC checkForSelectedFontWork(SdrView const* pSdrView, sal_uInt32& nCheckStatus); +bool SVXCORE_DLLPUBLIC checkForSelectedFontWork(SdrView const* pSdrView); bool SVXCORE_DLLPUBLIC checkForFontWork(SdrObject* pObj); class SAL_WARN_UNUSED SVXCORE_DLLPUBLIC FontworkBar final : public SfxShell -- cgit