From 9c90c5e4740763d116d1354d1e4315d338a92140 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Sat, 14 Dec 2019 09:30:57 +0200 Subject: loplugin:expandablemethods Change-Id: Ia8192e03feda9e8ae70e29d8dc98d995f015f9ce Reviewed-on: https://gerrit.libreoffice.org/85135 Tested-by: Jenkins Reviewed-by: Noel Grandin --- include/sfx2/dinfdlg.hxx | 10 ---------- include/sfx2/frame.hxx | 1 - include/sfx2/sidebar/SidebarDockingWindow.hxx | 3 --- include/sfx2/viewfrm.hxx | 2 -- include/svx/SvxPresetListBox.hxx | 1 - include/svx/fmsrcimp.hxx | 1 - include/svx/galtheme.hxx | 2 -- include/svx/langbox.hxx | 1 - include/svx/sdr/overlay/overlayanimatedbitmapex.hxx | 8 -------- include/svx/sdr/overlay/overlaybitmapex.hxx | 9 --------- include/svx/sdr/overlay/overlaytriangle.hxx | 6 ------ include/svx/sdrpaintwindow.hxx | 4 ---- include/svx/svdglue.hxx | 1 - include/svx/svdhlpln.hxx | 1 - include/svx/svdpagv.hxx | 2 -- 15 files changed, 52 deletions(-) (limited to 'include') diff --git a/include/sfx2/dinfdlg.hxx b/include/sfx2/dinfdlg.hxx index 559e529df658..7ceaaa79767b 100644 --- a/include/sfx2/dinfdlg.hxx +++ b/include/sfx2/dinfdlg.hxx @@ -96,32 +96,23 @@ public: bool isCmisDocument() const { return m_aCmisProperties.hasElements();} bool isAutoloadEnabled() const { return m_isAutoloadEnabled; } - void setAutoloadEnabled(bool i_val) { m_isAutoloadEnabled = i_val; } sal_Int32 getAutoloadDelay() const { return m_AutoloadDelay; } - void setAutoloadDelay(sal_Int32 i_val) { m_AutoloadDelay = i_val; } const OUString& getAutoloadURL() const { return m_AutoloadURL; } - void setAutoloadURL(const OUString& i_val) { m_AutoloadURL = i_val; } const OUString& getDefaultTarget() const { return m_DefaultTarget; } - void setDefaultTarget(const OUString& i_val) { m_DefaultTarget = i_val; } const OUString& getTemplateName() const { return m_TemplateName; } const OUString& getAuthor() const { return m_Author; } - void setAuthor(const OUString& i_val) { m_Author = i_val; } const css::util::DateTime& getCreationDate() const { return m_CreationDate; } const OUString& getModifiedBy() const { return m_ModifiedBy; } - void setModifiedBy(const OUString& i_val) { m_ModifiedBy = i_val; } const css::util::DateTime& getModificationDate() const { return m_ModificationDate; } const OUString& getPrintedBy() const { return m_PrintedBy; } - void setPrintedBy(const OUString& i_val) { m_PrintedBy = i_val; } const css::util::DateTime& getPrintDate() const { return m_PrintDate; } sal_Int16 getEditingCycles() const { return m_EditingCycles; } - void setEditingCycles(sal_Int16 i_val) { m_EditingCycles = i_val; } sal_Int32 getEditingDuration() const { return m_EditingDuration; } - void setEditingDuration(sal_Int32 i_val) { m_EditingDuration = i_val; } const OUString& getDescription() const { return m_Description; } void setDescription(const OUString& i_val) { m_Description = i_val; } const OUString& getKeywords() const { return m_Keywords; } @@ -139,7 +130,6 @@ public: void SetDeleteUserData( bool bSet ); void SetUseUserData( bool bSet ); void SetUseThumbnailSave( bool bSet ); - bool IsDeleteUserData() const { return m_bDeleteUserData;} bool IsUseUserData() const { return m_bUseUserData;} bool IsUseThumbnailSave() const { return m_bUseThumbnailSave;} diff --git a/include/sfx2/frame.hxx b/include/sfx2/frame.hxx index 65fdd26ebefb..4eb2c6115e24 100644 --- a/include/sfx2/frame.hxx +++ b/include/sfx2/frame.hxx @@ -81,7 +81,6 @@ private: std::unique_ptr< SfxFrame_Impl > pImpl; VclPtr pWindow; - void Close(); virtual ~SfxFrame(); SAL_DLLPRIVATE SfxFrame( vcl::Window& i_rContainerWindow ); diff --git a/include/sfx2/sidebar/SidebarDockingWindow.hxx b/include/sfx2/sidebar/SidebarDockingWindow.hxx index 0a02de481216..33ced4437582 100644 --- a/include/sfx2/sidebar/SidebarDockingWindow.hxx +++ b/include/sfx2/sidebar/SidebarDockingWindow.hxx @@ -43,9 +43,6 @@ public: virtual bool EventNotify(NotifyEvent& rEvent) override; virtual bool Close() override; - void SetReadyToDrag( bool bStartDrag ) { mbIsReadyToDrag = bStartDrag; } - bool IsReadyToDrag() const { return mbIsReadyToDrag; } - void NotifyResize(); using SfxDockingWindow::Close; diff --git a/include/sfx2/viewfrm.hxx b/include/sfx2/viewfrm.hxx index 8367cff4583b..cfd7fe068ae4 100644 --- a/include/sfx2/viewfrm.hxx +++ b/include/sfx2/viewfrm.hxx @@ -131,8 +131,6 @@ public: SfxViewFrame* GetTopViewFrame() const; bool DoClose(); - bool GetHasTitle() const - { return GetFrame().GetHasTitle(); } static void GetTargetList( TargetList& rList ) { SfxFrame::GetDefaultTargetList( rList ); } diff --git a/include/svx/SvxPresetListBox.hxx b/include/svx/SvxPresetListBox.hxx index 24715b08edb9..e2aadca2d75f 100644 --- a/include/svx/SvxPresetListBox.hxx +++ b/include/svx/SvxPresetListBox.hxx @@ -42,7 +42,6 @@ public: virtual void Resize() override; virtual bool Command(const CommandEvent& rEvent) override; - static sal_uInt32 getColumnCount() { return nColCount; } Size const & GetIconSize() const { return aIconSize; } void SetRenameHdl( const Link& rLink ) diff --git a/include/svx/fmsrcimp.hxx b/include/svx/fmsrcimp.hxx index d5fa188ed50f..582f4d83defe 100644 --- a/include/svx/fmsrcimp.hxx +++ b/include/svx/fmsrcimp.hxx @@ -317,7 +317,6 @@ private: // start a thread-search (or call SearchNextImpl directly, depending on the search mode) void ImplStartNextSearch(); - SVX_DLLPRIVATE void clearControlTexts(); SVX_DLLPRIVATE void fillControlTexts(const InterfaceArray& arrFields); // three methods implementing a complete search loop (null/not null, wildcard, SearchText) diff --git a/include/svx/galtheme.hxx b/include/svx/galtheme.hxx index f5bb333135aa..64a3c7e5cfc4 100644 --- a/include/svx/galtheme.hxx +++ b/include/svx/galtheme.hxx @@ -151,8 +151,6 @@ public: SAL_DLLPRIVATE void SetDragPos(sal_uInt32 nPos) { nDragPos = nPos; } SAL_DLLPRIVATE sal_uInt32 GetDragPos() const { return nDragPos; } - SAL_DLLPRIVATE bool IsThemeNameFromResource() const; - bool IsReadOnly() const; bool IsDefault() const; diff --git a/include/svx/langbox.hxx b/include/svx/langbox.hxx index 5d2d6cce610e..82c50321da6d 100644 --- a/include/svx/langbox.hxx +++ b/include/svx/langbox.hxx @@ -72,7 +72,6 @@ private: SVX_DLLPRIVATE void InsertLanguage(const LanguageType nLangType, sal_Int16 nType); SVX_DLLPRIVATE int ImplTypeToPos(LanguageType eType) const; - SVX_DLLPRIVATE void ImplClear(); DECL_LINK(ChangeHdl, weld::ComboBox&, void); public: SvxLanguageBox(std::unique_ptr pControl); diff --git a/include/svx/sdr/overlay/overlayanimatedbitmapex.hxx b/include/svx/sdr/overlay/overlayanimatedbitmapex.hxx index 426b0900be22..b6d9c46e3a47 100644 --- a/include/svx/sdr/overlay/overlayanimatedbitmapex.hxx +++ b/include/svx/sdr/overlay/overlayanimatedbitmapex.hxx @@ -67,14 +67,6 @@ namespace sdr double fRotation = 0.0); virtual ~OverlayAnimatedBitmapEx() override; - const BitmapEx& getBitmapEx1() const { return maBitmapEx1; } - const BitmapEx& getBitmapEx2() const { return maBitmapEx2; } - - sal_uInt16 getCenterX1() const { return mnCenterX1; } - sal_uInt16 getCenterY1() const { return mnCenterY1; } - sal_uInt16 getCenterX2() const { return mnCenterX2; } - sal_uInt16 getCenterY2() const { return mnCenterY2; } - // execute event from base class sdr::animation::Event. Default // implementation does nothing and does not create a new event. virtual void Trigger(sal_uInt32 nTime) override; diff --git a/include/svx/sdr/overlay/overlaybitmapex.hxx b/include/svx/sdr/overlay/overlaybitmapex.hxx index 8998237ed6b3..41c65b208126 100644 --- a/include/svx/sdr/overlay/overlaybitmapex.hxx +++ b/include/svx/sdr/overlay/overlaybitmapex.hxx @@ -54,15 +54,6 @@ namespace sdr double fShearX = 0.0, double fRotation = 0.0); virtual ~OverlayBitmapEx() override; - - const BitmapEx& getBitmapEx() const { return maBitmapEx; } - - sal_uInt16 getCenterX() const { return mnCenterX; } - sal_uInt16 getCenterY() const { return mnCenterY; } - - // get shearX and rotation - double getShearX() const { return mfShearX; } - double getRotation() const { return mfRotation; } }; } // end of namespace overlay } // end of namespace sdr diff --git a/include/svx/sdr/overlay/overlaytriangle.hxx b/include/svx/sdr/overlay/overlaytriangle.hxx index 15fad54a705b..a7fbe0cb6200 100644 --- a/include/svx/sdr/overlay/overlaytriangle.hxx +++ b/include/svx/sdr/overlay/overlaytriangle.hxx @@ -42,12 +42,6 @@ namespace sdr const basegfx::B2DPoint& rThirdPos, Color aTriangleColor); virtual ~OverlayTriangle() override; - - // get second position - const basegfx::B2DPoint& getSecondPosition() const { return maSecondPosition; } - - // get third position - const basegfx::B2DPoint& getThirdPosition() const { return maThirdPosition; } }; } // end of namespace overlay } // end of namespace sdr diff --git a/include/svx/sdrpaintwindow.hxx b/include/svx/sdrpaintwindow.hxx index d8ca1db6b735..287ec01b6195 100644 --- a/include/svx/sdrpaintwindow.hxx +++ b/include/svx/sdrpaintwindow.hxx @@ -97,7 +97,6 @@ public: ~SdrPaintWindow(); // data read accesses - SdrPaintView& GetPaintView() const { return mrPaintView; } OutputDevice& GetOutputDevice() const { return *mpOutputDevice; } vcl::Window* GetWindow() const { return mpWindow; } @@ -118,9 +117,6 @@ public: void SetOutputToWindow(bool bOutputToWindow) { mbOutputToWindow = bOutputToWindow; } - // Is OutDev a VirtualDevice? - bool OutputIsVirtualDevice() const { return mpOutputDevice->IsVirtual(); } - // Is OutDev a recording MetaFile? bool OutputToRecordingMetaFile() const; diff --git a/include/svx/svdglue.hxx b/include/svx/svdglue.hxx index 781be5e52651..9efb73172db9 100644 --- a/include/svx/svdglue.hxx +++ b/include/svx/svdglue.hxx @@ -121,7 +121,6 @@ public: SdrGluePointList() {}; SdrGluePointList(const SdrGluePointList& rSrcList) { *this=rSrcList; } - void Clear(); SdrGluePointList& operator=(const SdrGluePointList& rSrcList); sal_uInt16 GetCount() const { return sal_uInt16(aList.size()); } // At insert, the object (GluePoint) automatically gets an ID assigned. diff --git a/include/svx/svdhlpln.hxx b/include/svx/svdhlpln.hxx index 1afb7a139e03..acbc98dc9384 100644 --- a/include/svx/svdhlpln.hxx +++ b/include/svx/svdhlpln.hxx @@ -64,7 +64,6 @@ class SVX_DLLPUBLIC SdrHelpLineList { public: SdrHelpLineList() {} SdrHelpLineList(const SdrHelpLineList& rSrcList) { *this=rSrcList; } - void Clear(); SdrHelpLineList& operator=(const SdrHelpLineList& rSrcList); bool operator==(const SdrHelpLineList& rCmp) const; bool operator!=(const SdrHelpLineList& rCmp) const { return !operator==(rCmp); } diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx index fe5884b33809..2a3fd7717545 100644 --- a/include/svx/svdpagv.hxx +++ b/include/svx/svdpagv.hxx @@ -90,8 +90,6 @@ private: // was done SdrPageWindow* mpPreparedPageWindow; - // interface to SdrPageWindow - void ClearPageWindows(); public: sal_uInt32 PageWindowCount() const { return maPageWindows.size(); } SdrPageWindow* FindPageWindow( SdrPaintWindow& rPaintWindow ) const; -- cgit