From b8efcf225f3f8fe57a8a6a46d397c90d04e7073d Mon Sep 17 00:00:00 2001 From: Fridrich Štrba Date: Fri, 15 Mar 2013 13:51:20 +0100 Subject: Don't fail if the end of characters is reached after a field fdo#62299 Change-Id: Ib5327fe5a88036f718f90cc0e05f287dc1573d03 (cherry picked from commit aa479a03390e9a779321fae26146cc1493cdf97c) Reviewed-on: https://gerrit.libreoffice.org/2747 Reviewed-by: Petr Mladek Tested-by: Petr Mladek --- libvisio/UnpackedTarball_visio.mk | 6 ++++++ libvisio/libvisio-0.0.25.patch | 14 ++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 libvisio/libvisio-0.0.25.patch (limited to 'libvisio') diff --git a/libvisio/UnpackedTarball_visio.mk b/libvisio/UnpackedTarball_visio.mk index aa9113bafd6d..98313c170441 100644 --- a/libvisio/UnpackedTarball_visio.mk +++ b/libvisio/UnpackedTarball_visio.mk @@ -11,4 +11,10 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,visio)) $(eval $(call gb_UnpackedTarball_set_tarball,visio,$(VISIO_TARBALL))) +$(eval $(call gb_UnpackedTarball_set_patchlevel,visio,1)) + +$(eval $(call gb_UnpackedTarball_add_patches,visio,\ + libvisio/libvisio-0.0.25.patch \ +)) + # vim: set noet sw=4 ts=4: diff --git a/libvisio/libvisio-0.0.25.patch b/libvisio/libvisio-0.0.25.patch new file mode 100644 index 000000000000..6294548d1d8f --- /dev/null +++ b/libvisio/libvisio-0.0.25.patch @@ -0,0 +1,14 @@ +--- a/src/lib/VSDContentCollector.cpp ++++ b/src/lib/VSDContentCollector.cpp +@@ -2920,10 +2920,8 @@ void libvisio::VSDContentCollector::appendCharacters(WPXString &text, const std: + while (true) + { + if (iter == characters.end()) +- { +- fail = true; + break; +- } ++ + uint16_t character = *iter++; + character |= (uint16_t)(*iter++) << 8; + if (character == 0xfffc) -- cgit From 36a186821a17cd44d9581452c34f7863f6b5fcf9 Mon Sep 17 00:00:00 2001 From: Fridrich Štrba Date: Mon, 22 Apr 2013 11:53:32 +0200 Subject: Uploading new fresh wonderful libvisio-0.0.26 The release fixes several instances of data loss during conversion: * Fix missing WMFs in some Visio files * Don't truncate end of the text and some problems with text encoding and display: * Use ICU for text encoding conversions * Honour the "HideText" property (cherry picked from commit 105bb26e53049a317a43c13ebd9f706df760f27f) Conflicts: download.lst libvisio/ExternalProject_libvisio.mk Reviewed-on: https://gerrit.libreoffice.org/3552 Reviewed-by: Michael Meeks Tested-by: Michael Meeks (cherry picked from commit 0deb04fb8613c8aaf1ca9154b5ac53c0e0889d40) Change-Id: I00f18e64f60358f826720cc8d6af36c77a98a062 Reviewed-on: https://gerrit.libreoffice.org/3601 Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist Reviewed-by: Petr Mladek Tested-by: Petr Mladek --- libvisio/ExternalProject_libvisio.mk | 10 ++++++++-- libvisio/UnpackedTarball_visio.mk | 5 ----- libvisio/libvisio-0.0.25.patch | 14 -------------- libvisio/prj/build.lst | 2 +- 4 files changed, 9 insertions(+), 22 deletions(-) delete mode 100644 libvisio/libvisio-0.0.25.patch (limited to 'libvisio') diff --git a/libvisio/ExternalProject_libvisio.mk b/libvisio/ExternalProject_libvisio.mk index 38627990d270..940d3cd7713d 100644 --- a/libvisio/ExternalProject_libvisio.mk +++ b/libvisio/ExternalProject_libvisio.mk @@ -31,6 +31,7 @@ $(call gb_ExternalProject_get_state_target,libvisio,build) : && export LIBWPG_INCLUDE_DIR=$(OUTDIR)/inc/external \ && export LIBXML_INCLUDE_DIR=$(OUTDIR)/inc/external \ && export ZLIB_INCLUDE_DIR=$(OUTDIR)/inc/external/zlib \ + && export ICU_INCLUDE_DIR=$(OUTDIR)/inc/external \ && $(COMPATH)/vcpackages/vcbuild.exe libvisio.vcproj "Release|Win32" \ && touch $@ else ifeq ($(VCVER),100) @@ -41,6 +42,7 @@ $(call gb_ExternalProject_get_state_target,libvisio,build) : && export LIBWPG_INCLUDE_DIR=$(OUTDIR)/inc/external \ && export LIBXML_INCLUDE_DIR=$(OUTDIR)/inc/extrenal \ && export ZLIB_INCLUDE_DIR=$(OUTDIR)/inc/external/zlib \ + && export ICU_INCLUDE_DIR=$(OUTDIR)/inc/external \ && msbuild.exe libvisio.vcxproj /p:Configuration=Release \ && touch $@ else @@ -51,6 +53,7 @@ $(call gb_ExternalProject_get_state_target,libvisio,build) : && export LIBWPG_INCLUDE_DIR=$(OUTDIR)/inc/external \ && export LIBXML_INCLUDE_DIR=$(OUTDIR)/inc/external \ && export ZLIB_INCLUDE_DIR=$(OUTDIR)/inc/external/zlib \ + && export ICU_INCLUDE_DIR=$(OUTDIR)/inc/external \ && msbuild.exe libvisio.vcxproj /p:PlatformToolset=v110 /p:Configuration=Release \ && touch $@ endif @@ -59,8 +62,11 @@ else $(call gb_ExternalProject_get_state_target,libvisio,build) : cd $(EXTERNAL_WORKDIR) \ - && PKG_CONFIG="" \ - ./configure \ + && export PKG_CONFIG="" \ + && export ICU_LIBS=" " \ + $(if $(filter NO,$(SYSTEM_ICU)),&& export ICU_CFLAGS="-I$(OUTDIR)/inc/external") \ + $(if $(filter YES,$(SYSTEM_ICU)),&& export ICU_CFLAGS=" ") \ + && ./configure \ --with-pic \ --enable-static \ --disable-shared \ diff --git a/libvisio/UnpackedTarball_visio.mk b/libvisio/UnpackedTarball_visio.mk index 98313c170441..59c29ac83a7d 100644 --- a/libvisio/UnpackedTarball_visio.mk +++ b/libvisio/UnpackedTarball_visio.mk @@ -11,10 +11,5 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,visio)) $(eval $(call gb_UnpackedTarball_set_tarball,visio,$(VISIO_TARBALL))) -$(eval $(call gb_UnpackedTarball_set_patchlevel,visio,1)) - -$(eval $(call gb_UnpackedTarball_add_patches,visio,\ - libvisio/libvisio-0.0.25.patch \ -)) # vim: set noet sw=4 ts=4: diff --git a/libvisio/libvisio-0.0.25.patch b/libvisio/libvisio-0.0.25.patch deleted file mode 100644 index 6294548d1d8f..000000000000 --- a/libvisio/libvisio-0.0.25.patch +++ /dev/null @@ -1,14 +0,0 @@ ---- a/src/lib/VSDContentCollector.cpp -+++ b/src/lib/VSDContentCollector.cpp -@@ -2920,10 +2920,8 @@ void libvisio::VSDContentCollector::appendCharacters(WPXString &text, const std: - while (true) - { - if (iter == characters.end()) -- { -- fail = true; - break; -- } -+ - uint16_t character = *iter++; - character |= (uint16_t)(*iter++) << 8; - if (character == 0xfffc) diff --git a/libvisio/prj/build.lst b/libvisio/prj/build.lst index 5fdc953e050f..3bb2b3e01818 100644 --- a/libvisio/prj/build.lst +++ b/libvisio/prj/build.lst @@ -1,2 +1,2 @@ -vsd libvisio : LIBWPD:libwpd LIBWPD:libwpg BOOST:boost LIBXML2:libxml2 ZLIB:zlib soltools NULL +vsd libvisio : LIBWPD:libwpd LIBWPD:libwpg BOOST:boost ICU:icu LIBXML2:libxml2 ZLIB:zlib soltools NULL vsd libvisio\prj nmake - all vsd_libvisio NULL -- cgit