From 86a32589e90ee983159fb5b2c6a594428ab7d422 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 6 Mar 2014 15:29:08 +0200 Subject: Find places where OUString and OString are passed by value. It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361 --- linguistic/source/convdicxml.hxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'linguistic/source/convdicxml.hxx') diff --git a/linguistic/source/convdicxml.hxx b/linguistic/source/convdicxml.hxx index a11a50e75982..de5fada1466e 100644 --- a/linguistic/source/convdicxml.hxx +++ b/linguistic/source/convdicxml.hxx @@ -76,14 +76,14 @@ class ConvDicXMLImport : public SvXMLImport // but the language and conversion type will // still be determined! - sal_Int16 nLanguage; // language of the dictionary + sal_Int16 nLanguage; // language of the dictionary sal_Int16 nConversionType; // conversion type the dictionary is used for sal_Bool bSuccess; public: //!! see comment for pDic member - ConvDicXMLImport( ConvDic *pConvDic, const OUString /*&rFileName*/ ) : + ConvDicXMLImport( ConvDic *pConvDic, const OUString& /*&rFileName*/ ) : SvXMLImport ( comphelper::getProcessComponentContext(), "com.sun.star.lingu2.ConvDicXMLImport", IMPORT_ALL ), pDic ( pConvDic ) { -- cgit