From 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Thu, 29 Jan 2015 09:07:25 +0000 Subject: callcatcher: large newly detected unused methods post de-virtualization i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d --- .../source/filter/xfilter/xfcontentcontainer.cxx | 8 ------- .../source/filter/xfilter/xfcontentcontainer.hxx | 2 -- lotuswordpro/source/filter/xfilter/xflist.cxx | 25 ---------------------- lotuswordpro/source/filter/xfilter/xflist.hxx | 4 ---- 4 files changed, 39 deletions(-) (limited to 'lotuswordpro/source/filter') diff --git a/lotuswordpro/source/filter/xfilter/xfcontentcontainer.cxx b/lotuswordpro/source/filter/xfilter/xfcontentcontainer.cxx index a4a0c891b89b..ece407e9f6a2 100644 --- a/lotuswordpro/source/filter/xfilter/xfcontentcontainer.cxx +++ b/lotuswordpro/source/filter/xfilter/xfcontentcontainer.cxx @@ -73,14 +73,6 @@ void XFContentContainer::Add(XFContent *pContent) m_aContents.push_back(pContent); } -void XFContentContainer::InsertAtBegin(XFContent * pContent) -{ - m_aContents.insert(m_aContents.begin(), pContent); -} -void XFContentContainer::RemoveAt(sal_uInt32 nPos) -{ - m_aContents.erase(m_aContents.begin()+nPos); -} void XFContentContainer::Add(const OUString& text) { XFTextContent *pTC = new XFTextContent(); diff --git a/lotuswordpro/source/filter/xfilter/xfcontentcontainer.hxx b/lotuswordpro/source/filter/xfilter/xfcontentcontainer.hxx index d6f3c9998149..7abdf63c27ef 100644 --- a/lotuswordpro/source/filter/xfilter/xfcontentcontainer.hxx +++ b/lotuswordpro/source/filter/xfilter/xfcontentcontainer.hxx @@ -89,8 +89,6 @@ public: */ virtual void Add(XFContent *pContent); - void InsertAtBegin(XFContent *pContent); - void RemoveAt(sal_uInt32 nPos); rtl::Reference GetLastContent(); void RemoveLastContent(); /** diff --git a/lotuswordpro/source/filter/xfilter/xflist.cxx b/lotuswordpro/source/filter/xfilter/xflist.cxx index e3f102cbede5..a5b4722fb613 100644 --- a/lotuswordpro/source/filter/xfilter/xflist.cxx +++ b/lotuswordpro/source/filter/xfilter/xflist.cxx @@ -101,29 +101,4 @@ void XFList::ToXml(IXFStream *pStrm) pStrm->EndElement( "text:unordered-list" ); } -void XFList::StartList(IXFStream *pStrm, bool bContinueNumber) -{ - IXFAttrList *pAttrList = pStrm->GetAttrList(); - assert(NULL!=pAttrList); - - pAttrList->Clear(); - if( !GetStyleName().isEmpty() ) - pAttrList->AddAttribute( "text:style-name", GetStyleName() ); - if( bContinueNumber ) - pAttrList->AddAttribute( "text:continue-numbering", "true" ); - - if( m_bOrdered ) - pStrm->StartElement( "text:ordered-list" ); - else - pStrm->StartElement( "text:unordered-list" ); -} - -void XFList::EndList(IXFStream *pStrm) -{ - if( m_bOrdered ) - pStrm->EndElement( "text:ordered-list" ); - else - pStrm->EndElement( "text:unordered-list" ); -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/lotuswordpro/source/filter/xfilter/xflist.hxx b/lotuswordpro/source/filter/xfilter/xflist.hxx index 05531cccd858..b8b065c96bf5 100644 --- a/lotuswordpro/source/filter/xfilter/xflist.hxx +++ b/lotuswordpro/source/filter/xfilter/xflist.hxx @@ -92,10 +92,6 @@ public: */ virtual void ToXml(IXFStream *pStrm) SAL_OVERRIDE; - void StartList(IXFStream *pStrm, bool bContinueNumber = false); - - void EndList(IXFStream *pStrm); - private: bool m_bOrdered; bool m_bContinueNumber; -- cgit