From dfe21d378722e90218f2b97cea5c7a449d00b48c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 20 Mar 2025 08:14:33 +0200 Subject: loplugin:constparam in oox Change-Id: Iadec18cc82fd3fa8fb129698be92fed4ec2fbb1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183144 Reviewed-by: Noel Grandin Tested-by: Jenkins --- oox/source/export/drawingml.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'oox/source/export/drawingml.cxx') diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index 77baafbe755d..6f9905a4c612 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -2427,7 +2427,7 @@ void DrawingML::WriteShapeTransformation( const Reference< XShape >& rXShape, sa bFlipHWrite, bFlipVWrite, ExportRotateClockwisify(nRotation + nCameraRotation), IsGroupShape( rXShape )); } -static OUString lcl_GetTarget(const css::uno::Reference& xModel, OUString& rURL) +static OUString lcl_GetTarget(const css::uno::Reference& xModel, std::u16string_view rURL) { Reference xDPS(xModel, uno::UNO_QUERY_THROW); Reference xDrawPages(xDPS->getDrawPages(), uno::UNO_SET_THROW); @@ -2450,9 +2450,9 @@ static OUString lcl_GetTarget(const css::uno::Reference& xMo } if (sTarget.isEmpty()) { - sal_Int32 nSplit = rURL.lastIndexOf(' '); - if (nSplit > -1) - sTarget = OUString::Concat("slide") + rURL.subView(nSplit + 1) + ".xml"; + size_t nSplit = rURL.rfind(' '); + if (nSplit != std::u16string_view::npos) + sTarget = OUString::Concat("slide") + rURL.substr(nSplit + 1) + ".xml"; } return sTarget; -- cgit