From e2451bd729d0f1d795a5b689deba65bc4e9d92c6 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel@peralex.com>
Date: Fri, 25 Oct 2013 16:43:20 +0200
Subject: Convert indexOf->startsWith and lastIndexOf->endsWith

This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
---
 oox/source/export/chartexport.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'oox')

diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx
index 2dc837b1f746..36412be51e12 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -492,7 +492,7 @@ OUString ChartExport::parseFormula( const OUString& rRange )
         OSL_TRACE("ChartExport::parseFormula, parser is invalid");
         //FIXME: currently just using simple converter, e.g $Sheet1.$A$1:$C$1 -> Sheet1!$A$1:$C$1
         OUString aRange( rRange );
-        if( aRange.indexOf('$') == 0 )
+        if( aRange.startsWith("$") )
             aRange = aRange.copy(1);
         aRange = aRange.replaceAll(".$", "!$" );
         aResult = aRange;
-- 
cgit