From 1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 18 Apr 2019 15:13:19 +0200 Subject: optimise find/insert pattern if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin --- registry/source/regimpl.cxx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'registry/source') diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx index ea074732df12..63c937a1109a 100644 --- a/registry/source/regimpl.cxx +++ b/registry/source/regimpl.cxx @@ -1109,11 +1109,8 @@ static sal_uInt32 checkTypeReaders(RegistryTypeReader const & reader1, } for (sal_uInt32 i=0 ; i < reader2.getFieldCount(); i++) { - if (nameSet.find(reader2.getFieldName(i)) == nameSet.end()) - { - nameSet.insert(reader2.getFieldName(i)); + if (nameSet.insert(reader2.getFieldName(i)).second) count++; - } } return count; } -- cgit