From 93c64a61f2c84e684050294a1391cd32425b7837 Mon Sep 17 00:00:00 2001 From: Noel Date: Fri, 6 Nov 2020 20:01:50 +0200 Subject: loplugin:stringview Add new methods "subView" to O(U)String to return substring views of the underlying data. Add a clang plugin to warn when replacing existing calls to copy() would be better to use subView(). Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420 Tested-by: Jenkins Reviewed-by: Noel Grandin --- registry/source/regimpl.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'registry/source') diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx index 13b9d4251802..27a4592c9dc2 100644 --- a/registry/source/regimpl.cxx +++ b/registry/source/regimpl.cxx @@ -766,12 +766,12 @@ RegError ORegistry::eraseKey(ORegKey* pKey, const OUString& keyName) if (lastIndex >= 0) { - sRelativKey += keyName.copy(lastIndex + 1); + sRelativKey += keyName.subView(lastIndex + 1); if (sFullKeyName.getLength() > 1) sFullKeyName += keyName; else - sFullKeyName += keyName.copy(1); + sFullKeyName += keyName.subView(1); sFullPath = sFullKeyName.copy(0, keyName.lastIndexOf('/') + 1); } else -- cgit