From e2451bd729d0f1d795a5b689deba65bc4e9d92c6 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 25 Oct 2013 16:43:20 +0200 Subject: Convert indexOf->startsWith and lastIndexOf->endsWith This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669 --- registry/tools/regcompare.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'registry') diff --git a/registry/tools/regcompare.cxx b/registry/tools/regcompare.cxx index a08a3756c1ec..e3cbfedb7475 100644 --- a/registry/tools/regcompare.cxx +++ b/registry/tools/regcompare.cxx @@ -271,7 +271,7 @@ bool Options_Impl::matchedWithExcludeKey( const OUString& keyName) const StringSet::const_iterator first = m_excludeKeys.begin(), last = m_excludeKeys.end(); for (; first != last; ++first) { - if (keyName.indexOf(*first) == 0) + if (keyName.startsWith(*first)) return true; } } -- cgit