From 3c14d6545bb513dc825088d8d09263d9b16c21c8 Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Wed, 6 Mar 2013 21:19:42 +0100 Subject: remove ReportEngine2 interface Typical anti pattern in java is the overuse of interfaces. You only need an interface in java, if you have multiple different implementations. Otherwise you don't. Change-Id: If8b62adc56385f9b839dab36e8cbbf9f715e6017 --- .../java/com/sun/star/report/ReportEngine2.java | 46 ---------------------- .../star/report/pentaho/PentahoReportEngine.java | 3 +- 2 files changed, 1 insertion(+), 48 deletions(-) delete mode 100644 reportbuilder/java/com/sun/star/report/ReportEngine2.java (limited to 'reportbuilder/java') diff --git a/reportbuilder/java/com/sun/star/report/ReportEngine2.java b/reportbuilder/java/com/sun/star/report/ReportEngine2.java deleted file mode 100644 index 07a2fa09c1fe..000000000000 --- a/reportbuilder/java/com/sun/star/report/ReportEngine2.java +++ /dev/null @@ -1,46 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ -package com.sun.star.report; - -/** - * The job factory collects all required properties to build a reportJob - * object. Implementors should define a suitable set of properties to allow - * the configuration of the created report jobs. - * - * How these properties are collected is beyond the scope of this interface. - * For each type of Job, there should be separate job-factory (remote jobs - * vs. local jobs etc). - * - */ -public interface ReportEngine2 -{ - - public ReportJobDefinition createJobDefinition(); - - public ReportEngineMetaData getMetaData(); - - /** - * Open points: How to define scheduling? - * - * @param definition - * @return the report job definition for the job description. - * @throws JobDefinitionException - */ - public ReportJob createJob(ReportJobDefinition definition) - throws JobDefinitionException; -} diff --git a/reportbuilder/java/com/sun/star/report/pentaho/PentahoReportEngine.java b/reportbuilder/java/com/sun/star/report/pentaho/PentahoReportEngine.java index 01f5480714d4..a4ddc774c105 100644 --- a/reportbuilder/java/com/sun/star/report/pentaho/PentahoReportEngine.java +++ b/reportbuilder/java/com/sun/star/report/pentaho/PentahoReportEngine.java @@ -18,14 +18,13 @@ package com.sun.star.report.pentaho; import com.sun.star.report.JobDefinitionException; -import com.sun.star.report.ReportEngine2; import com.sun.star.report.ReportEngineMetaData; import com.sun.star.report.ReportJob; import com.sun.star.report.ReportJobDefinition; import com.sun.star.report.util.DefaultReportJobDefinition; import org.jfree.report.JFreeReportBoot; -public class PentahoReportEngine implements ReportEngine2 +public class PentahoReportEngine { private final ReportEngineMetaData metaData; -- cgit