From d4d37662b090cb237585156a47cd8e1f1cbe2656 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 11 Oct 2018 15:51:08 +0200 Subject: loplugin:constfields in reportdesign,sal,sax and improve the rewriter so I spend less time fixing formatting Change-Id: Ic2a6e5e31a5a202d2d02a47d77c484a57a5ec514 Reviewed-on: https://gerrit.libreoffice.org/61676 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- reportdesign/inc/RptObject.hxx | 8 ++++---- reportdesign/inc/UndoActions.hxx | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'reportdesign/inc') diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx index 31e3346c074d..f663a59787f7 100644 --- a/reportdesign/inc/RptObject.hxx +++ b/reportdesign/inc/RptObject.hxx @@ -46,7 +46,7 @@ typedef ::std::multimap< sal_Int16, OUString > IndexToNameMap; class REPORTDESIGN_DLLPUBLIC DlgEdHint: public SfxHint { private: - DlgEdHintKind eHintKind; + DlgEdHintKind const eHintKind; DlgEdHint(DlgEdHint&) = delete; void operator =(DlgEdHint&) = delete; @@ -68,7 +68,7 @@ protected: mutable css::uno::Reference< css::beans::XPropertyChangeListener> m_xPropertyChangeListener; mutable css::uno::Reference< css::report::XReportComponent> m_xReportComponent; css::uno::Reference< css::uno::XInterface > m_xKeepShapeAlive; - OUString m_sComponentName; + OUString const m_sComponentName; bool m_bIsListening; OObjectBase(const css::uno::Reference< css::report::XReportComponent>& _xComponent); @@ -215,7 +215,7 @@ private: void impl_createDataProvider_nothrow( const css::uno::Reference< css::frame::XModel>& _xModel); virtual void impl_setUnoShape( const css::uno::Reference< css::uno::XInterface >& rxUnoShape ) override; - sal_uInt16 m_nType; + sal_uInt16 const m_nType; bool m_bOnlyOnce; }; @@ -228,7 +228,7 @@ class REPORTDESIGN_DLLPUBLIC OUnoObject: public SdrUnoObj , public OObjectBase friend class OObjectBase; friend class DlgEdFactory; - sal_uInt16 m_nObjectType; + sal_uInt16 const m_nObjectType; // tdf#118730 remember if this object was created interactively (due to ::EndCreate being called) bool m_bSetDefaultLabel; diff --git a/reportdesign/inc/UndoActions.hxx b/reportdesign/inc/UndoActions.hxx index 9088eb693202..0219c9e39e45 100644 --- a/reportdesign/inc/UndoActions.hxx +++ b/reportdesign/inc/UndoActions.hxx @@ -170,7 +170,7 @@ namespace rptui m_xOwnElement; // object owned by the action css::uno::Reference< css::container::XIndexContainer > m_xContainer; - Action m_eAction; + Action const m_eAction; public: OUndoContainerAction(SdrModel& rMod @@ -231,9 +231,9 @@ namespace rptui class REPORTDESIGN_DLLPUBLIC ORptUndoPropertyAction: public OCommentUndoAction { css::uno::Reference< css::beans::XPropertySet> m_xObj; - OUString m_aPropertyName; - css::uno::Any m_aNewValue; - css::uno::Any m_aOldValue; + OUString const m_aPropertyName; + css::uno::Any const m_aNewValue; + css::uno::Any const m_aOldValue; /** sets either the old value or the new value again at the property set. * -- cgit