From bacee60a5920585feeff58840357aa7ac33e50a7 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 27 Oct 2014 14:02:38 +0200 Subject: ref-counting vcl::Window subclasses Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30 --- reportdesign/source/ui/dlg/GroupsSorting.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'reportdesign/source/ui') diff --git a/reportdesign/source/ui/dlg/GroupsSorting.cxx b/reportdesign/source/ui/dlg/GroupsSorting.cxx index 121a944a982a..aa8692522c76 100644 --- a/reportdesign/source/ui/dlg/GroupsSorting.cxx +++ b/reportdesign/source/ui/dlg/GroupsSorting.cxx @@ -182,7 +182,7 @@ OFieldExpressionControl::OFieldExpressionControl(OGroupsSortingDialog* _pParentD OFieldExpressionControl::~OFieldExpressionControl() { - acquire(); + WeakImplHelper1::acquire(); uno::Reference< report::XGroups > xGroups = m_pParent->getGroups(); xGroups->removeContainerListener(this); -- cgit