From a3bedb7ae8f23476843e00380aba05002aa1e827 Mon Sep 17 00:00:00 2001 From: Jochen Nitschke Date: Mon, 12 Jun 2017 02:12:56 +0200 Subject: use local statics for getUnoTunnelImplementationId replace uses of double checked locking pattern and rtl::Static Change-Id: I479d9d94f652b4fb4c67388405823a5f4e2b6ed4 Reviewed-on: https://gerrit.libreoffice.org/38690 Tested-by: Jenkins Reviewed-by: Noel Grandin --- reportdesign/source/core/api/ReportDefinition.cxx | 14 +++----------- reportdesign/source/core/api/Section.cxx | 14 +++----------- 2 files changed, 6 insertions(+), 22 deletions(-) (limited to 'reportdesign') diff --git a/reportdesign/source/core/api/ReportDefinition.cxx b/reportdesign/source/core/api/ReportDefinition.cxx index 4dcd58d1039e..eeb651da8a0f 100644 --- a/reportdesign/source/core/api/ReportDefinition.cxx +++ b/reportdesign/source/core/api/ReportDefinition.cxx @@ -2006,17 +2006,9 @@ uno::Sequence< sal_Int8 > SAL_CALL OReportDefinition::getImplementationId( ) uno::Sequence< sal_Int8 > OReportDefinition::getUnoTunnelImplementationId() { - static ::cppu::OImplementationId * pId = nullptr; - if (! pId) - { - ::osl::MutexGuard aGuard( ::osl::Mutex::getGlobalMutex() ); - if (! pId) - { - static ::cppu::OImplementationId aId; - pId = &aId; - } - } - return pId->getImplementationId(); + static ::cppu::OImplementationId implId; + + return implId.getImplementationId(); } uno::Reference< uno::XComponentContext > OReportDefinition::getContext() diff --git a/reportdesign/source/core/api/Section.cxx b/reportdesign/source/core/api/Section.cxx index e875191a7f5a..c8b29a7798b4 100644 --- a/reportdesign/source/core/api/Section.cxx +++ b/reportdesign/source/core/api/Section.cxx @@ -592,17 +592,9 @@ OSection* OSection::getImplementation( const uno::Reference< uno::XInterface >& uno::Sequence< sal_Int8 > OSection::getUnoTunnelImplementationId() { - static ::cppu::OImplementationId * pId = nullptr; - if (! pId) - { - ::osl::MutexGuard aGuard( ::osl::Mutex::getGlobalMutex() ); - if (! pId) - { - static ::cppu::OImplementationId aId; - pId = &aId; - } - } - return pId->getImplementationId(); + static ::cppu::OImplementationId implId; + + return implId.getImplementationId(); } void OSection::notifyElementAdded(const uno::Reference< drawing::XShape >& xShape ) -- cgit