From fc0d494b8936ab11abca761810de8a03f579edf5 Mon Sep 17 00:00:00 2001 From: Norbert Thiebaud Date: Sun, 19 Apr 2015 22:28:56 -0500 Subject: rsc crash on WIN64 due to LP64 rsc stash stuff in a 'value' filed that was defined as 'long' saddly it stash also pointer there... which on WIN64 truncate 64 bits pointers in 32 bits scalar. That went unnoticed for years because on every other platform sizeof(long) = sizeof(void*) Change-Id: I218ae181c9d6b64ade457ee49942d1d07a933bb7 Reviewed-on: https://gerrit.libreoffice.org/15394 Tested-by: Jenkins Reviewed-by: Norbert Thiebaud --- rsc/source/tools/rsctree.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'rsc/source/tools') diff --git a/rsc/source/tools/rsctree.cxx b/rsc/source/tools/rsctree.cxx index c72c77f8d5e6..a080349cf80d 100644 --- a/rsc/source/tools/rsctree.cxx +++ b/rsc/source/tools/rsctree.cxx @@ -155,9 +155,9 @@ NameNode * NameNode::Remove( NameNode * pRemove ) COMPARE NameNode::Compare( const NameNode * pCompare ) const { - if( reinterpret_cast(this) < reinterpret_cast(pCompare) ) + if( reinterpret_cast(this) < reinterpret_cast(pCompare) ) return LESS; - else if( reinterpret_cast(this) > reinterpret_cast(pCompare) ) + else if( reinterpret_cast(this) > reinterpret_cast(pCompare) ) return GREATER; else return EQUAL; @@ -165,9 +165,9 @@ COMPARE NameNode::Compare( const NameNode * pCompare ) const COMPARE NameNode::Compare( const void * pCompare ) const { - if( reinterpret_cast(this) < reinterpret_cast(pCompare) ) + if( reinterpret_cast(this) < reinterpret_cast(pCompare) ) return LESS; - else if( reinterpret_cast(this) > reinterpret_cast(pCompare) ) + else if( reinterpret_cast(this) > reinterpret_cast(pCompare) ) return GREATER; else return EQUAL; -- cgit