From e2451bd729d0f1d795a5b689deba65bc4e9d92c6 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 25 Oct 2013 16:43:20 +0200 Subject: Convert indexOf->startsWith and lastIndexOf->endsWith This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669 --- sal/osl/w32/path_helper.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sal/osl/w32') diff --git a/sal/osl/w32/path_helper.cxx b/sal/osl/w32/path_helper.cxx index b91c1874c4b7..c58d70dd18e4 100644 --- a/sal/osl/w32/path_helper.cxx +++ b/sal/osl/w32/path_helper.cxx @@ -54,7 +54,7 @@ void osl_systemPathEnsureSeparator(/*inout*/ rtl_uString** ppustrPath) rtl_uString_assign(ppustrPath, path.pData); } - OSL_POSTCOND(path.lastIndexOf(BACKSLASH) == (path.getLength() - 1), \ + OSL_POSTCOND(path.endsWith(BACKSLASH), \ "osl_systemPathEnsureSeparator: Post condition failed"); } -- cgit