From 2bc1a0431becd1c6d4c888a6e301237dcecefd97 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 19 Aug 2021 08:08:20 +0200 Subject: New loplugin:unusedcapturedefault In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building without --with-latest-c++) requires ROW_RANGE (a local const int variable from the enclosing TestFormula::testTdf97369) to be captured, even though all uses of that variable within the lambda body are constant expressions. That is still true at least for the latest Visual Studio 2019 version 16.11.1. (This is not an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down, as they, in addition to using that ROW_RANGE, also use the local const double variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so they are implicitly captured and loplugin:unusedcapturedefault does not suggest dropping those lambdas' capture-defaults in the first place.) Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- sal/qa/osl/file/osl_File.cxx | 2 +- sal/rtl/bootstrap.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'sal') diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx index 9280ceb40406..232bd87693f2 100644 --- a/sal/qa/osl/file/osl_File.cxx +++ b/sal/qa/osl/file/osl_File.cxx @@ -4683,7 +4683,7 @@ namespace osl_Directory static OUString const & get_test_path() { - static OUString test_path = [&]() + static OUString test_path = []() { OUString tmp; osl::FileBase::RC rc = osl::FileBase::getTempDirURL(tmp); diff --git a/sal/rtl/bootstrap.cxx b/sal/rtl/bootstrap.cxx index 52ee7f38d24d..4f7a827fd77b 100644 --- a/sal/rtl/bootstrap.cxx +++ b/sal/rtl/bootstrap.cxx @@ -154,7 +154,7 @@ static bool getFromCommandLineArgs( { OSL_ASSERT(value); - static NameValueVector nameValueVector = [&]() + static NameValueVector nameValueVector = []() { NameValueVector tmp; -- cgit