From 7fbfc12474b85b31c9d120898fff6e226d76d662 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 4 Dec 2014 15:49:48 +0100 Subject: Still no need for osl_setCommandArgs (TOCTOU and all) Change-Id: I81253c8790b631117634bafa4eea65991a975ba0 --- sal/osl/unx/process_impl.cxx | 2 +- sal/osl/w32/process.cxx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) (limited to 'sal') diff --git a/sal/osl/unx/process_impl.cxx b/sal/osl/unx/process_impl.cxx index 7d8cc81aa655..b5c1fe76fb9c 100644 --- a/sal/osl/unx/process_impl.cxx +++ b/sal/osl/unx/process_impl.cxx @@ -205,7 +205,7 @@ void SAL_CALL osl_setCommandArgs (int argc, char ** argv) { assert(argc > 0); pthread_mutex_lock (&(g_command_args.m_mutex)); - assert (g_command_args.m_nCount == 0); + SAL_WARN_IF(g_command_args.m_nCount != 0, "sal.osl", "args already set"); if (g_command_args.m_nCount == 0) { rtl_uString** ppArgs = (rtl_uString**)rtl_allocateZeroMemory (argc * sizeof(rtl_uString*)); diff --git a/sal/osl/w32/process.cxx b/sal/osl/w32/process.cxx index 49259e03410a..0ab85800704d 100644 --- a/sal/osl/w32/process.cxx +++ b/sal/osl/w32/process.cxx @@ -374,6 +374,7 @@ void SAL_CALL osl_setCommandArgs (int argc, char ** argv) { assert(argc > 0); osl_acquireMutex (*osl_getGlobalMutex()); + SAL_WARN_IF(g_command_args.m_nCount != 0, "sal.osl", "args already set"); if (g_command_args.m_nCount == 0) { rtl_uString** ppArgs = osl_createCommandArgs_Impl (argc, argv); -- cgit