From d06e5adc21f29c8954021a60445a5c0810731d9e Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Mon, 26 Aug 2013 07:41:14 +0300 Subject: Be careful not to access a string out of bounds Change-Id: Ibc43ffa0c535e0baf1bb6d8b213320da345a3d65 --- sal/osl/unx/uunxapi.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sal') diff --git a/sal/osl/unx/uunxapi.cxx b/sal/osl/unx/uunxapi.cxx index 3052538f484f..866cef2a8593 100644 --- a/sal/osl/unx/uunxapi.cxx +++ b/sal/osl/unx/uunxapi.cxx @@ -272,7 +272,8 @@ int open_c(const char *cpPath, int oflag, int mode) // scoped bookmark for it so that we can access the file in // the future, too. (For the "Recent Files" functionality.) const char *sandbox = [NSHomeDirectory() UTF8String]; - if (!(memcmp(sandbox, cpPath, strlen(sandbox)) == 0 && + if (!(strlen(cpPath) > strlen(sandbox) && + memcmp(sandbox, cpPath, strlen(sandbox)) == 0 && cpPath[strlen(sandbox)] == '/')) { NSURL *url = [NSURL fileURLWithPath:[NSString stringWithUTF8String:cpPath]]; -- cgit