From 56e6f0da839c53867947d1e06f0e733022df7d0e Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 4 Sep 2015 12:16:17 +0200 Subject: new loplugin: badvectorinit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit look for places calling the 1-argument vector fill constructor and then immediately called push_back, which is generally a sign that its leaving empty slots. Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517 Reviewed-on: https://gerrit.libreoffice.org/17525 Reviewed-by: Björn Michaelsen Tested-by: Björn Michaelsen --- sax/qa/cppunit/test_converter.cxx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'sax/qa') diff --git a/sax/qa/cppunit/test_converter.cxx b/sax/qa/cppunit/test_converter.cxx index 67290d59facd..1e3061e8090f 100644 --- a/sax/qa/cppunit/test_converter.cxx +++ b/sax/qa/cppunit/test_converter.cxx @@ -664,9 +664,7 @@ void doTestDecodeBase64(const uno::Sequence& aPass, char const*const p void ConverterTest::testBase64() { - std::vector< sal_Int8 > tempSeq(4); - for(sal_Int8 i = 0; i<4; ++i) - tempSeq.push_back(i); + std::vector< sal_Int8 > tempSeq { 0, 0, 0, 0, 0, 1, 2, 3 }; uno::Sequence< sal_Int8 > tempSequence = comphelper::containerToSequence(tempSeq); doTestEncodeBase64("AAAAAAABAgM=", tempSequence); doTestDecodeBase64(tempSequence, "AAAAAAABAgM="); -- cgit