From b7654432bfeca619b7657abc8d27193e44cf4dfc Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 20 Mar 2018 12:54:11 +0200 Subject: loplugin:useuniqueptr in ScDocument and fix bug where we were deleting a pointer to an object we did not own via pFormatExchangeList Change-Id: I488c679734c48bd21bc6be04837e037e97550647 Reviewed-on: https://gerrit.libreoffice.org/51668 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sc/inc/textuno.hxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sc/inc/textuno.hxx') diff --git a/sc/inc/textuno.hxx b/sc/inc/textuno.hxx index c88a2831261d..0ffbcc483949 100644 --- a/sc/inc/textuno.hxx +++ b/sc/inc/textuno.hxx @@ -325,7 +325,7 @@ class ScCellTextData : public SfxListener protected: ScDocShell* pDocShell; ScAddress aCellPos; - ScFieldEditEngine* pEditEngine; + std::unique_ptr pEditEngine; SvxEditEngineForwarder* pForwarder; ScCellEditSource* pOriginalSource; bool bDataValid; @@ -342,7 +342,7 @@ public: // helper functions for ScSharedCellEditSource: virtual SvxTextForwarder* GetTextForwarder(); void UpdateData(); - ScFieldEditEngine* GetEditEngine() { GetTextForwarder(); return pEditEngine; } + ScFieldEditEngine* GetEditEngine() { GetTextForwarder(); return pEditEngine.get(); } ScCellEditSource* GetOriginalSource(); // used as argument for SvxUnoText ctor -- cgit 5-4 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
AgeCommit message (Expand)Author
2020-07-30Add an optional Gerrit change ID to testfeatureJan-Marek Glogowski
2020-05-27logerrit: Don't suggest to set oneself a username.Guilhem Moulin
2020-03-02fix get_SHA_for_change in logerrit scriptNoel Grandin
2020-02-28tdf#105204 fix shellcheck warnings in logerritIlmari Lauhakangas
2020-01-16logerrit: Upgrade URIs to https://Guilhem Moulin
2020-01-16logerrit setup: refactor key-based SSH handlingGuilhem Moulin
2020-01-15logerrit: atomically create ~/.ssh with restrictive modeGuilhem Moulin
2020-01-06logerrit: support submitting private and wip changesIlmari Lauhakangas
2019-12-26Fix typoAndrea Gelmini
2019-09-06Fixing '....'Andrea Gelmini
2019-03-05Fix typoAndrea Gelmini
2017-09-06Improve error message on ssh login failure.Shinnok