From 58806ee799072776e04d49d95dcba525575f9ce7 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 19 Jul 2016 10:49:48 +0200 Subject: clang-tidy performance-unnecessary-value-param in sc Change-Id: I1941c050a385e3a1020c5d2495471f5805c4c180 --- sc/qa/unit/helper/qahelper.cxx | 2 +- sc/qa/unit/helper/qahelper.hxx | 2 +- sc/qa/unit/helper/xpath.cxx | 2 +- sc/qa/unit/helper/xpath.hxx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'sc/qa/unit/helper') diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx index ac61dc2f9955..e3493a18652a 100644 --- a/sc/qa/unit/helper/qahelper.cxx +++ b/sc/qa/unit/helper/qahelper.cxx @@ -747,7 +747,7 @@ std::string to_std_string(const OUString& rStr) } -void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* expected, const char* msg, CppUnit::SourceLine sourceLine) +void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* expected, const char* msg, CppUnit::SourceLine const & sourceLine) { ScTokenArray* pCode = getTokens(rDoc, rPos); if (!pCode) diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx index 9929c6c800c1..dc4afd19bf53 100644 --- a/sc/qa/unit/helper/qahelper.hxx +++ b/sc/qa/unit/helper/qahelper.hxx @@ -249,7 +249,7 @@ public: CPPUNIT_ASSERT_EQUAL( static_cast(expected), static_cast(result) ); SCQAHELPER_DLLPUBLIC void checkFormula(ScDocument& rDoc, const ScAddress& rPos, - const char* expected, const char* msg, CppUnit::SourceLine sourceLine); + const char* expected, const char* msg, CppUnit::SourceLine const & sourceLine); #define ASSERT_FORMULA_EQUAL(doc, pos, expected, msg) \ checkFormula(doc, pos, expected, msg, CPPUNIT_SOURCELINE()) diff --git a/sc/qa/unit/helper/xpath.cxx b/sc/qa/unit/helper/xpath.cxx index 2117b749b326..2d047b60bf61 100644 --- a/sc/qa/unit/helper/xpath.cxx +++ b/sc/qa/unit/helper/xpath.cxx @@ -25,7 +25,7 @@ xmlDocPtr XPathHelper::parseExport(ScDocShell& rShell, uno::Reference pTempFile, uno::Reference const & xSFactory, const OUString& rFile) +xmlDocPtr XPathHelper::parseExport(std::shared_ptr const & pTempFile, uno::Reference const & xSFactory, const OUString& rFile) { // Read the XML stream we're interested in. uno::Reference xNameAccess = packages::zip::ZipFileAccess::createWithURL(comphelper::getComponentContext(xSFactory), pTempFile->GetURL()); diff --git a/sc/qa/unit/helper/xpath.hxx b/sc/qa/unit/helper/xpath.hxx index 91a81e1253c3..86d1d279576e 100644 --- a/sc/qa/unit/helper/xpath.hxx +++ b/sc/qa/unit/helper/xpath.hxx @@ -53,7 +53,7 @@ namespace XPathHelper * Should be used when the same exported file is used for testing different files in * the same zip file. */ - SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory, + SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr const & pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile); } -- cgit