From 5b112c8f8843613873181fce50990a8feef837ca Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 5 Aug 2022 11:21:44 +0200 Subject: clang-tidy modernize-pass-by-value in sc Change-Id: Ia7ff651d1cbc119b36a9f8052594d03650988f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137848 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sc/source/ui/dataprovider/dataprovider.cxx | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'sc/source/ui/dataprovider/dataprovider.cxx') diff --git a/sc/source/ui/dataprovider/dataprovider.cxx b/sc/source/ui/dataprovider/dataprovider.cxx index 72f674a7b99d..cc83294366cb 100644 --- a/sc/source/ui/dataprovider/dataprovider.cxx +++ b/sc/source/ui/dataprovider/dataprovider.cxx @@ -24,6 +24,7 @@ #include #include #include +#include using namespace com::sun::star; @@ -63,10 +64,10 @@ std::unique_ptr DataProvider::FetchStreamFromURL(const OUString& rURL, } } -ExternalDataSource::ExternalDataSource(const OUString& rURL, - const OUString& rProvider, ScDocument* pDoc) - : maURL(rURL) - , maProvider(rProvider) +ExternalDataSource::ExternalDataSource(OUString aURL, + OUString aProvider, ScDocument* pDoc) + : maURL(std::move(aURL)) + , maProvider(std::move(aProvider)) , mpDoc(pDoc) { } @@ -246,8 +247,8 @@ void ScDBDataManager::WriteToDoc(ScDocument& rDoc) pDocShell->PostPaint(aDestRange, PaintPartFlags::All); } -ScDBDataManager::ScDBDataManager(const OUString& rDBName, ScDocument* pDoc): - maDBName(rDBName), +ScDBDataManager::ScDBDataManager(OUString aDBName, ScDocument* pDoc): + maDBName(std::move(aDBName)), mpDoc(pDoc) { } -- cgit