From 4ce537563a763f8822928e8140e639a554fbd7d3 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 3 Jun 2015 12:02:36 +0200 Subject: Apply new VclPtr clang plugin to catch potential problems. Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins Reviewed-by: Michael Meeks Tested-by: Michael Meeks --- sc/source/ui/dbgui/tpsubt.cxx | 14 ++++++++++---- sc/source/ui/dbgui/validate.cxx | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) (limited to 'sc/source/ui/dbgui') diff --git a/sc/source/ui/dbgui/tpsubt.cxx b/sc/source/ui/dbgui/tpsubt.cxx index c41bbc1a07ca..e36c39f1e963 100644 --- a/sc/source/ui/dbgui/tpsubt.cxx +++ b/sc/source/ui/dbgui/tpsubt.cxx @@ -387,15 +387,21 @@ IMPL_LINK( ScTpSubTotalGroup, CheckHdl, void *, pLb ) VclPtr ScTpSubTotalGroup1::Create( vcl::Window* pParent, const SfxItemSet* rArgSet ) - { return VclPtr( new ScTpSubTotalGroup1( pParent, *rArgSet ), SAL_NO_ACQUIRE ); } +{ + return VclPtr::Create( pParent, *rArgSet ); +} VclPtr ScTpSubTotalGroup2::Create( vcl::Window* pParent, const SfxItemSet* rArgSet ) - { return VclPtr( new ScTpSubTotalGroup2( pParent, *rArgSet ), SAL_NO_ACQUIRE ); } +{ + return VclPtr::Create( pParent, *rArgSet ); +} VclPtr ScTpSubTotalGroup3::Create( vcl::Window* pParent, const SfxItemSet* rArgSet ) - { return VclPtr( new ScTpSubTotalGroup3( pParent, *rArgSet ), SAL_NO_ACQUIRE ); } +{ + return VclPtr::Create( pParent, *rArgSet ); +} ScTpSubTotalGroup1::ScTpSubTotalGroup1( vcl::Window* pParent, const SfxItemSet& rArgSet ) : ScTpSubTotalGroup( pParent, rArgSet ) @@ -487,7 +493,7 @@ void ScTpSubTotalOptions::Init() VclPtr ScTpSubTotalOptions::Create( vcl::Window* pParent, const SfxItemSet* rArgSet ) { - return VclPtr( new ScTpSubTotalOptions( pParent, *rArgSet ), SAL_NO_ACQUIRE ); + return VclPtr::Create( pParent, *rArgSet ); } void ScTpSubTotalOptions::Reset( const SfxItemSet* /* rArgSet */ ) diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx index 54edca1eed8a..23fb0f8df0ee 100644 --- a/sc/source/ui/dbgui/validate.cxx +++ b/sc/source/ui/dbgui/validate.cxx @@ -407,7 +407,7 @@ void ScTPValidationValue::Init() VclPtr ScTPValidationValue::Create( vcl::Window* pParent, const SfxItemSet* rArgSet ) { - return VclPtr(new ScTPValidationValue( pParent, *rArgSet ), SAL_NO_ACQUIRE); + return VclPtr::Create( pParent, *rArgSet ); } void ScTPValidationValue::Reset( const SfxItemSet* rArgSet ) -- cgit