From 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 Mon Sep 17 00:00:00 2001 From: Noel Date: Fri, 13 Nov 2020 14:29:59 +0200 Subject: loplugin:stringviewparam check methods too not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sc/source/ui/inc/TableFillingAndNavigationTools.hxx | 10 +++++----- sc/source/ui/inc/drawview.hxx | 2 +- sc/source/ui/inc/viewfunc.hxx | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'sc/source/ui/inc') diff --git a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx index d24535c54298..c4974bbd1bc6 100644 --- a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx +++ b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx @@ -40,11 +40,11 @@ public: void autoReplaceAddress(const OUString& aVariable, ScAddress const & aAddress); void autoReplaceUses3D(bool bUse3D) { mbUse3D = bUse3D; } - void applyRange(const OUString& aVariable, const ScRange& aRange, bool b3D = true); - void applyRangeList(const OUString& aVariable, const ScRangeList& aRangeList, sal_Unicode cDelimiter ); - void applyAddress(const OUString& aVariable, const ScAddress& aAddress, bool b3D = true); - void applyString(const OUString& aVariable, const OUString& aValue); - void applyNumber(const OUString& aVariable, sal_Int32 aValue); + void applyRange(std::u16string_view aVariable, const ScRange& aRange, bool b3D = true); + void applyRangeList(std::u16string_view aVariable, const ScRangeList& aRangeList, sal_Unicode cDelimiter ); + void applyAddress(std::u16string_view aVariable, const ScAddress& aAddress, bool b3D = true); + void applyString(std::u16string_view aVariable, std::u16string_view aValue); + void applyNumber(std::u16string_view aVariable, sal_Int32 aValue); }; class AddressWalker diff --git a/sc/source/ui/inc/drawview.hxx b/sc/source/ui/inc/drawview.hxx index 6ecf44456059..3a2e844a8031 100644 --- a/sc/source/ui/inc/drawview.hxx +++ b/sc/source/ui/inc/drawview.hxx @@ -152,7 +152,7 @@ public: const Graphic& rGraphic, const OUString& rBeginUndoText, const OUString& rFile, - const OUString& rFilter); + std::u16string_view rFilter); static void CheckOle( const SdrMarkList& rMarkList, bool& rAnyOle, bool& rOneOle ); diff --git a/sc/source/ui/inc/viewfunc.hxx b/sc/source/ui/inc/viewfunc.hxx index bb0644ba856b..78241137592e 100644 --- a/sc/source/ui/inc/viewfunc.hxx +++ b/sc/source/ui/inc/viewfunc.hxx @@ -149,7 +149,7 @@ public: bool PasteBitmapEx( const Point&, const BitmapEx& ); bool PasteMetaFile( const Point&, const GDIMetaFile& ); bool PasteGraphic( const Point& rPos, const Graphic& rGraphic, - const OUString& rFile, const OUString& rFilter ); + const OUString& rFile, std::u16string_view rFilter ); bool PasteBookmark( SotClipboardFormatId nFormatId, const css::uno::Reference< css::datatransfer::XTransferable >& rxTransferable, SCCOL nPosX, SCROW nPosY ); -- cgit