From 01caa0ffbca6f1ee30cf0f25d2e462b12cb7535c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 15 Aug 2018 13:42:09 +0200 Subject: loplugin:returnconstant in ScViewUtil Change-Id: Id28d24e05e0f416ffaab4e22ad1189834e1570ab Reviewed-on: https://gerrit.libreoffice.org/59131 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sc/source/ui/inc/viewutil.hxx | 2 +- sc/source/ui/view/viewutil.cxx | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'sc') diff --git a/sc/source/ui/inc/viewutil.hxx b/sc/source/ui/inc/viewutil.hxx index 5678033c969a..8d57370b950f 100644 --- a/sc/source/ui/inc/viewutil.hxx +++ b/sc/source/ui/inc/viewutil.hxx @@ -43,7 +43,7 @@ enum class ScUpdateMode { All, Marks }; class SC_DLLPUBLIC ScViewUtil { public: - static bool ExecuteCharMap( const SvxFontItem& rOldFont, + static void ExecuteCharMap( const SvxFontItem& rOldFont, SfxViewFrame& rFrame ); static bool IsActionShown( const ScChangeAction& rAction, diff --git a/sc/source/ui/view/viewutil.cxx b/sc/source/ui/view/viewutil.cxx index 60689970c0b4..c2150253e692 100644 --- a/sc/source/ui/view/viewutil.cxx +++ b/sc/source/ui/view/viewutil.cxx @@ -325,7 +325,7 @@ void ScViewUtil::HideDisabledSlot( SfxItemSet& rSet, SfxBindings& rBindings, sal rSet.DisableItem( nSlotId ); } -bool ScViewUtil::ExecuteCharMap( const SvxFontItem& rOldFont, +void ScViewUtil::ExecuteCharMap( const SvxFontItem& rOldFont, SfxViewFrame& rFrame ) { SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); @@ -334,7 +334,6 @@ bool ScViewUtil::ExecuteCharMap( const SvxFontItem& rOldFont, aSet.Put( SvxFontItem( rOldFont.GetFamily(), rOldFont.GetFamilyName(), rOldFont.GetStyleName(), rOldFont.GetPitch(), rOldFont.GetCharSet(), aSet.GetPool()->GetWhich( SID_ATTR_CHAR_FONT ) ) ); ScopedVclPtr pDlg(pFact->CreateCharMapDialog(rFrame.GetWindow().GetFrameWeld(), aSet, true)); pDlg->Execute(); - return false; } bool ScViewUtil::IsFullScreen( const SfxViewShell& rViewShell ) -- cgit