From a03df92a0ca6ae04cb99bb9ab678e31d82363879 Mon Sep 17 00:00:00 2001
From: Mike Kaganski <mike.kaganski@collabora.com>
Date: Tue, 8 Oct 2024 02:08:00 +0500
Subject: tdf#163344: improve Converter::convertDuration

Let it use the same calculation as ImpSvNumberInputScan::GetTimeRef.
Decreases rounding errors.

Change-Id: I6474a1a5913d78c236adc511389c4abcebed2de6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174650
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 9c9d2e21be06fa1c806c110812d6df783109d8b9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174664
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
---
 sc/qa/unit/data/functions/date_time/fods/time.fods | 169 +--------------------
 1 file changed, 5 insertions(+), 164 deletions(-)

(limited to 'sc')

diff --git a/sc/qa/unit/data/functions/date_time/fods/time.fods b/sc/qa/unit/data/functions/date_time/fods/time.fods
index f2f2df5512a9..40e60f1271f0 100644
--- a/sc/qa/unit/data/functions/date_time/fods/time.fods
+++ b/sc/qa/unit/data/functions/date_time/fods/time.fods
@@ -748,9 +748,11 @@
      <table:table-cell table:number-columns-repeated="4"/>
     </table:table-row>
     <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="7"/>
+     <table:table-cell table:style-name="ce13" table:formula="of:=TIME(14;30;0)" office:value-type="time"/>
+     <table:table-cell table:style-name="ce16" office:value-type="time" office:time-value="PT14H30M00S"/>
+     <table:table-cell table:style-name="ce17" table:formula="of:=ORG.LIBREOFFICE.RAWSUBTRACT([.A11];[.B11])=0" office:value-type="boolean"/>
+     <table:table-cell table:style-name="ce21" table:formula="of:=FORMULA([.A11])" office:value-type="string"/>
+     <table:table-cell table:number-columns-repeated="6"/>
      <table:table-cell office:value-type="float" office:value="19" calcext:value-type="float">
       <text:p>19</text:p>
      </table:table-cell>
@@ -772,167 +774,6 @@
      <table:table-cell table:style-name="ce19"/>
      <table:table-cell table:number-columns-repeated="12"/>
     </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce20"/>
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="2"/>
-     <table:table-cell table:number-columns-repeated="10"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:style-name="ce15" table:number-columns-repeated="5"/>
-     <table:table-cell table:number-columns-repeated="4"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="6"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="5"/>
-     <table:table-cell table:number-columns-repeated="10"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce20"/>
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="2"/>
-     <table:table-cell table:number-columns-repeated="10"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce20"/>
-     <table:table-cell table:style-name="ce14" table:number-columns-repeated="2"/>
-     <table:table-cell table:number-columns-repeated="4"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="6"/>
-     <table:table-cell table:style-name="ce24"/>
-     <table:table-cell table:number-columns-repeated="5"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="12"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="6"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="12"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="6"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="6">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="12"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="6"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="4">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="12"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="6"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="12"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="6"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="2"/>
-     <table:table-cell table:style-name="ce19"/>
-     <table:table-cell table:number-columns-repeated="12"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce22" table:number-columns-repeated="5"/>
-     <table:table-cell/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce25" table:number-columns-repeated="5"/>
-     <table:table-cell table:style-name="ce26" office:value-type="string" calcext:value-type="string">
-      <text:p>Age</text:p>
-     </table:table-cell>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="2">
-     <table:table-cell table:number-columns-repeated="9"/>
-     <table:table-cell table:style-name="ce26" table:number-columns-repeated="6"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2" table:number-rows-repeated="1048515">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
-    <table:table-row table:style-name="ro2">
-     <table:table-cell table:number-columns-repeated="15"/>
-    </table:table-row>
     <calcext:conditional-formats>
      <calcext:conditional-format calcext:target-range-address="Sheet2.C18:Sheet2.C41 Sheet2.C2:Sheet2.C15">
       <calcext:condition calcext:apply-style-name="Default" calcext:value="=&quot;&quot;" calcext:base-cell-address="Sheet2.C2"/>
-- 
cgit