From cb9bcae7baf70eba601daba8857bdea783ad0dca Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel@peralex.com>
Date: Mon, 11 Apr 2016 11:38:23 +0200
Subject: clang-tidy performance-unnecessary-value-param in formula

Change-Id: I9f90c55f74216c2f3452e5b30d85b304668330b3
---
 sc/inc/compiler.hxx              | 6 +++---
 sc/source/core/tool/compiler.cxx | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

(limited to 'sc')

diff --git a/sc/inc/compiler.hxx b/sc/inc/compiler.hxx
index a0370233a6ff..d8f5e3e3cede 100644
--- a/sc/inc/compiler.hxx
+++ b/sc/inc/compiler.hxx
@@ -445,9 +445,9 @@ public:
 private:
     // FormulaCompiler
     virtual OUString FindAddInFunction( const OUString& rUpperName, bool bLocalFirst ) const override;
-    virtual void fillFromAddInCollectionUpperName( NonConstOpCodeMapPtr xMap ) const override;
-    virtual void fillFromAddInCollectionEnglishName( NonConstOpCodeMapPtr xMap ) const override;
-    virtual void fillFromAddInMap( NonConstOpCodeMapPtr xMap, formula::FormulaGrammar::Grammar _eGrammar ) const override;
+    virtual void fillFromAddInCollectionUpperName( const NonConstOpCodeMapPtr& xMap ) const override;
+    virtual void fillFromAddInCollectionEnglishName( const NonConstOpCodeMapPtr& xMap ) const override;
+    virtual void fillFromAddInMap( const NonConstOpCodeMapPtr& xMap, formula::FormulaGrammar::Grammar _eGrammar ) const override;
     virtual void fillAddInToken(::std::vector< css::sheet::FormulaOpCodeMapEntry >& _rVec,bool _bIsEnglish) const override;
 
     virtual bool HandleExternalReference(const formula::FormulaToken& _aToken) override;
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 38e2da084060..51cb1e9a893b 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -97,7 +97,7 @@ static const sal_Char* pInternal[2] = { "TTT", "__DEBUG_VAR" };
 
 using namespace ::com::sun::star::i18n;
 
-void ScCompiler::fillFromAddInMap( NonConstOpCodeMapPtr xMap,FormulaGrammar::Grammar _eGrammar  ) const
+void ScCompiler::fillFromAddInMap( const NonConstOpCodeMapPtr& xMap,FormulaGrammar::Grammar _eGrammar  ) const
 {
     size_t nSymbolOffset;
     switch( _eGrammar )
@@ -125,7 +125,7 @@ void ScCompiler::fillFromAddInMap( NonConstOpCodeMapPtr xMap,FormulaGrammar::Gra
     }
 }
 
-void ScCompiler::fillFromAddInCollectionUpperName( NonConstOpCodeMapPtr xMap ) const
+void ScCompiler::fillFromAddInCollectionUpperName( const NonConstOpCodeMapPtr& xMap ) const
 {
     ScUnoAddInCollection* pColl = ScGlobal::GetAddInCollection();
     long nCount = pColl->GetFuncCount();
@@ -138,7 +138,7 @@ void ScCompiler::fillFromAddInCollectionUpperName( NonConstOpCodeMapPtr xMap ) c
     }
 }
 
-void ScCompiler::fillFromAddInCollectionEnglishName( NonConstOpCodeMapPtr xMap ) const
+void ScCompiler::fillFromAddInCollectionEnglishName( const NonConstOpCodeMapPtr& xMap ) const
 {
     ScUnoAddInCollection* pColl = ScGlobal::GetAddInCollection();
     long nCount = pColl->GetFuncCount();
-- 
cgit