From bb06f51308428500c9c8d11ae05f0aa03ecc179c Mon Sep 17 00:00:00 2001 From: Noel Date: Wed, 18 Nov 2020 10:10:40 +0200 Subject: loplugin:stringviewparam extend to comparison operators which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin --- scaddins/source/analysis/analysishelper.hxx | 4 ++-- scaddins/source/datefunc/datefunc.hxx | 2 +- scaddins/source/pricing/pricing.hxx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'scaddins') diff --git a/scaddins/source/analysis/analysishelper.hxx b/scaddins/source/analysis/analysishelper.hxx index 26c9a668ed49..6a8c3bb87ab9 100644 --- a/scaddins/source/analysis/analysishelper.hxx +++ b/scaddins/source/analysis/analysishelper.hxx @@ -223,7 +223,7 @@ public: inline const OUString& GetSuffix() const; sal_uInt16 GetStrIndex( sal_uInt16 nParamNum ) const; - inline bool Is( const OUString& rCompareTo ) const; + inline bool Is( std::u16string_view rCompareTo ) const; inline const std::vector & GetCompNameList() const; @@ -618,7 +618,7 @@ inline const OUString& FuncData::GetSuffix() const } -inline bool FuncData::Is( const OUString& r ) const +inline bool FuncData::Is( std::u16string_view r ) const { return aIntName == r; } diff --git a/scaddins/source/datefunc/datefunc.hxx b/scaddins/source/datefunc/datefunc.hxx index 590ac64ceec1..666b221b81db 100644 --- a/scaddins/source/datefunc/datefunc.hxx +++ b/scaddins/source/datefunc/datefunc.hxx @@ -77,7 +77,7 @@ public: bool IsDouble() const { return bDouble; } sal_uInt16 GetStrIndex( sal_uInt16 nParam ) const; - bool Is( const OUString& rCompare ) const + bool Is( std::u16string_view rCompare ) const { return aIntName == rCompare; } const std::vector& GetCompNameList() const { return aCompList; } diff --git a/scaddins/source/pricing/pricing.hxx b/scaddins/source/pricing/pricing.hxx index 9fe391f349ef..ffc13499831d 100644 --- a/scaddins/source/pricing/pricing.hxx +++ b/scaddins/source/pricing/pricing.hxx @@ -92,7 +92,7 @@ public: bool IsDouble() const { return bDouble; } sal_uInt16 GetStrIndex( sal_uInt16 nParam ) const; - bool Is( const OUString& rCompare ) const + bool Is( std::u16string_view rCompare ) const { return aIntName == rCompare; } const std::vector& GetCompNameList() const { return aCompList; } -- cgit