From 6851c5fd4337af38884d16c05695da7e4e059dcc Mon Sep 17 00:00:00 2001 From: Andras Timar Date: Thu, 28 Feb 2013 13:17:39 +0100 Subject: bin PATCH_SO_NAME crack In VersionInfo of Windows executables the FileDescription property originally contained 80 times 'x' character. These executables were marked as PATCH_SO_NAME and later the installer maker perl program replaced the xxxxxxxxxxx to the actual file description which was defined in scp2. WHy was it good, I have no idea. The problem was that it happened after postprocess, where we signed the binaries, thus diigital signature became corrupted. It is better to give file descriptions via makefiles. Change-Id: Id5ad4470bb7a6313b33fbba09d72d9a009163a89 --- scp2/source/base/file_base.scp | 5 ----- scp2/source/calc/file_calc.scp | 5 ----- scp2/source/crashrep/file_crashrep.scp | 5 ----- scp2/source/draw/file_draw.scp | 5 ----- scp2/source/impress/file_impress.scp | 5 ----- scp2/source/math/file_math.scp | 5 ----- scp2/source/ooo/common_brand.scp | 8 -------- scp2/source/writer/file_writer.scp | 8 +------- 8 files changed, 1 insertion(+), 45 deletions(-) (limited to 'scp2/source') diff --git a/scp2/source/base/file_base.scp b/scp2/source/base/file_base.scp index 59b0f74d3be5..f684e1d5319c 100644 --- a/scp2/source/base/file_base.scp +++ b/scp2/source/base/file_base.scp @@ -31,12 +31,7 @@ File gid_File_Exe_Sbase BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(sbase); - #ifdef WNT - FileDescription = "%PRODUCTNAME Base"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End #if defined WNT diff --git a/scp2/source/calc/file_calc.scp b/scp2/source/calc/file_calc.scp index 5c4105698489..f5985567846f 100644 --- a/scp2/source/calc/file_calc.scp +++ b/scp2/source/calc/file_calc.scp @@ -82,10 +82,5 @@ File gid_File_Exe_Scalc BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(scalc); - #ifdef WNT - FileDescription = "%PRODUCTNAME Calc"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End diff --git a/scp2/source/crashrep/file_crashrep.scp b/scp2/source/crashrep/file_crashrep.scp index 481d9fcbb119..81c9c497d2ab 100644 --- a/scp2/source/crashrep/file_crashrep.scp +++ b/scp2/source/crashrep/file_crashrep.scp @@ -33,12 +33,7 @@ File gid_Brand_File_Bin_Crashreport BIN_FILE_BODY; Name = EXENAME(crashrep); Dir = gid_Brand_Dir_Program; - #ifdef WNT - FileDescription = "%PRODUCTNAME Crashreporter"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End #ifdef WNT diff --git a/scp2/source/draw/file_draw.scp b/scp2/source/draw/file_draw.scp index 26428ab53ad4..676112f33285 100644 --- a/scp2/source/draw/file_draw.scp +++ b/scp2/source/draw/file_draw.scp @@ -47,10 +47,5 @@ File gid_File_Exe_Sdraw BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(sdraw); - #ifdef WNT - FileDescription = "%PRODUCTNAME Draw"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End diff --git a/scp2/source/impress/file_impress.scp b/scp2/source/impress/file_impress.scp index 1958046e84fe..88cbf694d05e 100644 --- a/scp2/source/impress/file_impress.scp +++ b/scp2/source/impress/file_impress.scp @@ -68,12 +68,7 @@ File gid_File_Exe_Simpress BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(simpress); - #ifdef WNT - FileDescription = "%PRODUCTNAME Impress"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End // configuration files for custom animation effects diff --git a/scp2/source/math/file_math.scp b/scp2/source/math/file_math.scp index 8da10318744f..acbb3c9362a7 100644 --- a/scp2/source/math/file_math.scp +++ b/scp2/source/math/file_math.scp @@ -63,10 +63,5 @@ File gid_File_Exe_Smath BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(smath); - #ifdef WNT - FileDescription = "%PRODUCTNAME Math"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp index 5f9f957ccd8f..4194becac3bb 100644 --- a/scp2/source/ooo/common_brand.scp +++ b/scp2/source/ooo/common_brand.scp @@ -495,11 +495,7 @@ File gid_Brand_File_Bin_Soffice Styles = (PACKED, SUBST_FILENAME); #else Name = EXENAME(soffice); - #ifdef WNT - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif #endif End @@ -515,11 +511,7 @@ End File gid_Brand_File_Bin_Soffice_Bin BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; -#if defined WNT - Styles = (PACKED, PATCH_SO_NAME); -#else Styles = (PACKED); -#endif Name = "soffice.bin"; End diff --git a/scp2/source/writer/file_writer.scp b/scp2/source/writer/file_writer.scp index 4d8e65a264aa..d02047f72354 100644 --- a/scp2/source/writer/file_writer.scp +++ b/scp2/source/writer/file_writer.scp @@ -35,12 +35,7 @@ File gid_File_Exe_Swriter BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(swriter); - #ifdef WNT - FileDescription = "%PRODUCTNAME Writer"; - Styles = (PACKED, PATCH_SO_NAME); - #else Styles = (PACKED); - #endif End #ifdef WNT @@ -48,8 +43,7 @@ File gid_File_Exe_Sweb BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(sweb); - FileDescription = "%PRODUCTNAME Writer(Web)"; - Styles = (PACKED, PATCH_SO_NAME); + Styles = (PACKED); End #endif -- cgit