From 789055bc2acb4c71483fd60ea258d158bd5aec10 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Apr 2016 16:39:03 +0200 Subject: clang-tidy performance-unnecessary-copy-initialization probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- scripting/source/dlgprov/dlgevtatt.cxx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'scripting') diff --git a/scripting/source/dlgprov/dlgevtatt.cxx b/scripting/source/dlgprov/dlgevtatt.cxx index dd2d18f92e7c..b0a51fe1047c 100644 --- a/scripting/source/dlgprov/dlgevtatt.cxx +++ b/scripting/source/dlgprov/dlgevtatt.cxx @@ -624,17 +624,16 @@ namespace dlgprov if( pResMgr ) { OUString aRes( ResId(STR_ERRUNOEVENTBINDUNG, *pResMgr) ); - OUString aQuoteChar( "\"" ); + OUString aQuoteChar( "\"" ); - OUString aOURes = aRes; - sal_Int32 nIndex = aOURes.indexOf( '%' ); + sal_Int32 nIndex = aRes.indexOf( '%' ); OUString aOUFinal; - aOUFinal += aOURes.copy( 0, nIndex ); + aOUFinal += aRes.copy( 0, nIndex ); aOUFinal += aQuoteChar; aOUFinal += aMethodName; aOUFinal += aQuoteChar; - aOUFinal += aOURes.copy( nIndex + 2 ); + aOUFinal += aRes.copy( nIndex + 2 ); ScopedVclPtrInstance::Create(nullptr, aOUFinal)->Execute(); } -- cgit