From 9649026cf50533595c172cd81b96acd45603d86b Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Apr 2016 11:54:45 +0200 Subject: clang-tidy performance-unnecessary-value-param in sd Change-Id: Id55410931305a9695a001977a5227b430a984e99 --- sd/inc/CustomAnimationEffect.hxx | 12 ++++++------ sd/inc/CustomAnimationPreset.hxx | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'sd/inc') diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx index a8dcbe5c1a42..507bd9fc8fde 100644 --- a/sd/inc/CustomAnimationEffect.hxx +++ b/sd/inc/CustomAnimationEffect.hxx @@ -206,7 +206,7 @@ private: struct stl_CustomAnimationEffect_search_node_predict { stl_CustomAnimationEffect_search_node_predict( const css::uno::Reference< css::animations::XAnimationNode >& xSearchNode ); - bool operator()( CustomAnimationEffectPtr pEffect ) const; + bool operator()( const CustomAnimationEffectPtr& pEffect ) const; const css::uno::Reference< css::animations::XAnimationNode >& mxSearchNode; }; @@ -310,10 +310,10 @@ public: SAL_DLLPRIVATE CustomAnimationTextGroupPtr findGroup( sal_Int32 nGroupId ); CustomAnimationTextGroupPtr createTextGroup( CustomAnimationEffectPtr pEffect, sal_Int32 nTextGrouping, double fTextGroupingAuto, bool bAnimateForm, bool bTextReverse ); - SAL_DLLPRIVATE void setTextGrouping( CustomAnimationTextGroupPtr pTextGroup, sal_Int32 nTextGrouping ); - SAL_DLLPRIVATE void setAnimateForm( CustomAnimationTextGroupPtr pTextGroup, bool bAnimateForm ); - SAL_DLLPRIVATE void setTextGroupingAuto( CustomAnimationTextGroupPtr pTextGroup, double fTextGroupingAuto ); - SAL_DLLPRIVATE void setTextReverse( CustomAnimationTextGroupPtr pTextGroup, bool bAnimateForm ); + SAL_DLLPRIVATE void setTextGrouping( const CustomAnimationTextGroupPtr& pTextGroup, sal_Int32 nTextGrouping ); + SAL_DLLPRIVATE void setAnimateForm( const CustomAnimationTextGroupPtr& pTextGroup, bool bAnimateForm ); + SAL_DLLPRIVATE void setTextGroupingAuto( const CustomAnimationTextGroupPtr& pTextGroup, double fTextGroupingAuto ); + SAL_DLLPRIVATE void setTextReverse( const CustomAnimationTextGroupPtr& pTextGroup, bool bAnimateForm ); SAL_DLLPRIVATE sal_Int32 getSequenceType() const { return mnSequenceType; } @@ -327,7 +327,7 @@ protected: SAL_DLLPRIVATE virtual void implRebuild(); SAL_DLLPRIVATE virtual void reset(); - SAL_DLLPRIVATE void createTextGroupParagraphEffects( CustomAnimationTextGroupPtr pTextGroup, CustomAnimationEffectPtr pEffect, bool bUsed ); + SAL_DLLPRIVATE void createTextGroupParagraphEffects( const CustomAnimationTextGroupPtr& pTextGroup, const CustomAnimationEffectPtr& pEffect, bool bUsed ); SAL_DLLPRIVATE void notify_listeners(); diff --git a/sd/inc/CustomAnimationPreset.hxx b/sd/inc/CustomAnimationPreset.hxx index 8c8ef2fb518c..bd3da582d849 100644 --- a/sd/inc/CustomAnimationPreset.hxx +++ b/sd/inc/CustomAnimationPreset.hxx @@ -45,7 +45,7 @@ class CustomAnimationPreset public: CustomAnimationPreset( CustomAnimationEffectPtr pEffect ); - void add( CustomAnimationEffectPtr pEffect ); + void add( const CustomAnimationEffectPtr& pEffect ); SD_DLLPUBLIC css::uno::Reference< css::animations::XAnimationNode > create( const OUString& rstrSubType ); @@ -109,7 +109,7 @@ public: SAL_DLLPRIVATE const PresetCategoryList& getMotionPathsPresets() const { return maMotionPathsPresets; } SAL_DLLPRIVATE const PresetCategoryList& getMiscPresets() const { return maMiscPresets; } - SAL_DLLPRIVATE void changePresetSubType( CustomAnimationEffectPtr pEffect, const OUString& rPresetSubType ) const; + SAL_DLLPRIVATE void changePresetSubType( const CustomAnimationEffectPtr& pEffect, const OUString& rPresetSubType ) const; private: SAL_DLLPRIVATE void importEffects(); -- cgit