From dafae0fe31353a8092334328d499bc108d39e44c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 3 Aug 2017 10:23:01 +0200 Subject: loplugin:constparams in sd Change-Id: I833c6da99d5ccb8f6a8b5c905bee73b75fde0a89 Reviewed-on: https://gerrit.libreoffice.org/40700 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sd/inc/Annotation.hxx | 4 ++-- sd/inc/CustomAnimationEffect.hxx | 2 +- sd/inc/EffectMigration.hxx | 6 +++--- sd/inc/OutlinerIterator.hxx | 2 +- sd/inc/TransitionPreset.hxx | 2 +- sd/inc/animations.hxx | 2 +- sd/inc/drawdoc.hxx | 18 +++++++++--------- sd/inc/notifydocumentevent.hxx | 4 ++-- sd/inc/sdmod.hxx | 4 ++-- sd/inc/sdpage.hxx | 6 +++--- sd/inc/stlpool.hxx | 6 +++--- sd/inc/stlsheet.hxx | 2 +- sd/inc/textapi.hxx | 2 +- 13 files changed, 30 insertions(+), 30 deletions(-) (limited to 'sd/inc') diff --git a/sd/inc/Annotation.hxx b/sd/inc/Annotation.hxx index d13496cbdcc9..68c343866913 100644 --- a/sd/inc/Annotation.hxx +++ b/sd/inc/Annotation.hxx @@ -46,10 +46,10 @@ sal_uInt32 getAnnotationId(const css::uno::Reference & const SdPage* getAnnotationPage(const css::uno::Reference& xAnnotation); void LOKCommentNotify(CommentNotificationType nType, const SfxViewShell* pViewShell, - css::uno::Reference& rxAnnotation); + css::uno::Reference const & rxAnnotation); void LOKCommentNotifyAll(CommentNotificationType nType, - css::uno::Reference& rxAnnotation); + css::uno::Reference const & rxAnnotation); } #endif diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx index 187437f90b7d..9d292a055845 100644 --- a/sd/inc/CustomAnimationEffect.hxx +++ b/sd/inc/CustomAnimationEffect.hxx @@ -232,7 +232,7 @@ public: CustomAnimationTextGroup( const css::uno::Reference< css::drawing::XShape >& rTarget, sal_Int32 nGroupId ); void reset(); - void addEffect( CustomAnimationEffectPtr& pEffect ); + void addEffect( CustomAnimationEffectPtr const & pEffect ); const EffectSequence& getEffects() const { return maEffects; } diff --git a/sd/inc/EffectMigration.hxx b/sd/inc/EffectMigration.hxx index f1702b1d7f8f..9dc388c0ecb2 100644 --- a/sd/inc/EffectMigration.hxx +++ b/sd/inc/EffectMigration.hxx @@ -63,12 +63,12 @@ public: static bool GetDimPrevious( SvxShape* pShape ); static void SetPresentationOrder( SvxShape* pShape, sal_Int32 nNewPos ); static sal_Int32 GetPresentationOrder( SvxShape* pShape ); - static void UpdateSoundEffect( SvxShape* pShape, SdAnimationInfo* pInfo ); + static void UpdateSoundEffect( SvxShape* pShape, SdAnimationInfo const * pInfo ); static OUString GetSoundFile( SvxShape* pShape ); static bool GetSoundOn( SvxShape* pShape ); - static void SetAnimationPath( SvxShape* pShape, SdrPathObj* pPathObj ); - static void CreateAnimatedGroup(SdrObjGroup& rGroupObj, SdPage& rPage); + static void SetAnimationPath( SvxShape* pShape, SdrPathObj const * pPathObj ); + static void CreateAnimatedGroup(SdrObjGroup const & rGroupObj, SdPage& rPage); static void DocumentLoaded(SdDrawDocument & rDoc); }; diff --git a/sd/inc/OutlinerIterator.hxx b/sd/inc/OutlinerIterator.hxx index 0bb838b75d7e..206b00a12d9f 100644 --- a/sd/inc/OutlinerIterator.hxx +++ b/sd/inc/OutlinerIterator.hxx @@ -265,7 +265,7 @@ private: This specifies at which object the iterator points initially. */ static sal_Int32 GetPageIndex ( - SdDrawDocument* pDocument, + SdDrawDocument const * pDocument, const std::shared_ptr& rpViewShell, PageKind ePageKind, EditMode eEditMode, diff --git a/sd/inc/TransitionPreset.hxx b/sd/inc/TransitionPreset.hxx index 1d696d515dd7..922901c4d1d0 100644 --- a/sd/inc/TransitionPreset.hxx +++ b/sd/inc/TransitionPreset.hxx @@ -70,7 +70,7 @@ private: OUString maVariantLabel; static bool importTransitionsFile( TransitionPresetList& rList, - css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceFactory, + css::uno::Reference< css::lang::XMultiServiceFactory > const & xServiceFactory, const OUString& aFilename ); }; diff --git a/sd/inc/animations.hxx b/sd/inc/animations.hxx index 4d7755f4ccbf..7d5081c774ef 100644 --- a/sd/inc/animations.hxx +++ b/sd/inc/animations.hxx @@ -42,7 +42,7 @@ typedef std::list< AfterEffectNode > AfterEffectNodeList; /** inserts the animation node in the given AfterEffectNode at the correct position in the timing hierarchy of its master */ -SD_DLLPUBLIC void stl_process_after_effect_node_func(AfterEffectNode& rNode); +SD_DLLPUBLIC void stl_process_after_effect_node_func(AfterEffectNode const & rNode); } // namespace sd; diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx index 591fe2fedad1..e0836dcdee7b 100644 --- a/sd/inc/drawdoc.hxx +++ b/sd/inc/drawdoc.hxx @@ -177,8 +177,8 @@ private: ::std::unique_ptr mpMasterPageListWatcher; SAL_DLLPRIVATE void UpdatePageObjectsInNotes(sal_uInt16 nStartPos); - SAL_DLLPRIVATE void UpdatePageRelativeURLs(SdPage* pPage, sal_uInt16 nPos, sal_Int32 nIncrement); - SAL_DLLPRIVATE void FillOnlineSpellingList(SdPage* pPage); + SAL_DLLPRIVATE void UpdatePageRelativeURLs(SdPage const * pPage, sal_uInt16 nPos, sal_Int32 nIncrement); + SAL_DLLPRIVATE void FillOnlineSpellingList(SdPage const * pPage); SAL_DLLPRIVATE void SpellObject(SdrTextObj* pObj); DECL_DLLPRIVATE_LINK(WorkStartupHdl, Timer *, void); @@ -236,7 +236,7 @@ public: If a reference document is given, the sizes and border settings of that document are used for newly created slides. */ - void CreateFirstPages( SdDrawDocument* pRefDocument = nullptr ); + void CreateFirstPages( SdDrawDocument const * pRefDocument = nullptr ); bool CreateMissingNotesAndHandoutPages(); SAL_DLLPRIVATE void MovePage(sal_uInt16 nPgNum, sal_uInt16 nNewPos) override; @@ -258,7 +258,7 @@ public: std::vector &rExchangeList, bool bLink, bool bReplace, sal_uInt16 nPgPos, ::sd::DrawDocShell* pBookmarkDocSh, - Point* pObjPos); + Point const * pObjPos); SAL_DLLPRIVATE bool IsStartWithPresentation() const { return mbStartWithPresentation;} SAL_DLLPRIVATE void SetStartWithPresentation( bool bStartWithPresentation ); @@ -332,7 +332,7 @@ public: SAL_DLLPRIVATE bool InsertBookmarkAsObject(const std::vector &rBookmarkList, const std::vector &rExchangeList, ::sd::DrawDocShell* pBookmarkDocSh, - Point* pObjPos, bool bCalcObjCount); + Point const * pObjPos, bool bCalcObjCount); void CloseBookmarkDoc(); @@ -371,7 +371,7 @@ public: sal_uInt16 GetActiveSdPageCount() const; - SAL_DLLPRIVATE sal_uInt16 GetMasterPageUserCount(SdrPage* pMaster) const; + SAL_DLLPRIVATE sal_uInt16 GetMasterPageUserCount(SdrPage const * pMaster) const; SAL_DLLPRIVATE const sd::PresentationSettings& getPresentationSettings() const { return maPresentationSettings; } SAL_DLLPRIVATE sd::PresentationSettings& getPresentationSettings() { return maPresentationSettings; } @@ -408,7 +408,7 @@ public: SAL_DLLPRIVATE void StopOnlineSpelling(); SAL_DLLPRIVATE void StartOnlineSpelling(bool bForceSpelling=true); - SAL_DLLPRIVATE void ImpOnlineSpellCallback(SpellCallbackInfo* pInfo, SdrObject* pObj, SdrOutliner* pOutl); + SAL_DLLPRIVATE void ImpOnlineSpellCallback(SpellCallbackInfo* pInfo, SdrObject* pObj, SdrOutliner const * pOutl); SAL_DLLPRIVATE void InsertObject(SdrObject* pObj); SAL_DLLPRIVATE void RemoveObject(SdrObject* pObj); @@ -441,7 +441,7 @@ public: static SdAnimationInfo* GetShapeUserData(SdrObject& rObject, bool bCreate = false ); - SAL_DLLPRIVATE static SdIMapInfo* GetIMapInfo( SdrObject* pObject ); + SAL_DLLPRIVATE static SdIMapInfo* GetIMapInfo( SdrObject const * pObject ); SAL_DLLPRIVATE static IMapObject* GetHitIMapObject( SdrObject* pObject, const Point& rWinPoint ); SAL_DLLPRIVATE CharClass* GetCharClass() const { return mpCharClass; } @@ -653,7 +653,7 @@ private: page. */ SAL_DLLPRIVATE void SetupNewPage ( - SdPage* pPreviousPage, + SdPage const * pPreviousPage, SdPage* pPage, const OUString& sPageName, sal_uInt16 nInsertionPoint, diff --git a/sd/inc/notifydocumentevent.hxx b/sd/inc/notifydocumentevent.hxx index 1a0689834fb2..c16f16c13e5b 100644 --- a/sd/inc/notifydocumentevent.hxx +++ b/sd/inc/notifydocumentevent.hxx @@ -24,9 +24,9 @@ class SdDrawDocument; -void NotifyDocumentEvent( SdDrawDocument* pDocument, const OUString& rEventName ); +void NotifyDocumentEvent( SdDrawDocument const * pDocument, const OUString& rEventName ); -void NotifyDocumentEvent( SdDrawDocument* pDocument, const OUString& rEventName, const css::uno::Reference< css::uno::XInterface >& xSource ); +void NotifyDocumentEvent( SdDrawDocument const * pDocument, const OUString& rEventName, const css::uno::Reference< css::uno::XInterface >& xSource ); #endif diff --git a/sd/inc/sdmod.hxx b/sd/inc/sdmod.hxx index 3e50eec0f2f6..397bfc292fb3 100644 --- a/sd/inc/sdmod.hxx +++ b/sd/inc/sdmod.hxx @@ -138,7 +138,7 @@ protected: virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override; private: - SfxFrame* ExecuteNewDocument( SfxRequest& rReq ); + SfxFrame* ExecuteNewDocument( SfxRequest const & rReq ); static SfxFrame* CreateEmptyDocument( const css::uno::Reference< css::frame::XFrame >& i_rFrame ); static SfxFrame* CreateFromTemplate( const OUString& rTemplatePath, const css::uno::Reference< css::frame::XFrame >& i_rFrame ); @@ -151,7 +151,7 @@ private: This typically is the unmodified request from a execute() function from where this function is called. */ - static bool OutlineToImpress(SfxRequest& rRequest); + static bool OutlineToImpress(SfxRequest const & rRequest); /** Add an eventlistener as soon as possible in sd, allows to use remote devices to start the slideshow elegantly, and respecting diff --git a/sd/inc/sdpage.hxx b/sd/inc/sdpage.hxx index 4fef9099de04..b4b72390b6bf 100644 --- a/sd/inc/sdpage.hxx +++ b/sd/inc/sdpage.hxx @@ -301,7 +301,7 @@ public: @throws css::uno::RuntimeException */ - void setAnimationNode( css::uno::Reference< css::animations::XAnimationNode >& xNode ); + void setAnimationNode( css::uno::Reference< css::animations::XAnimationNode > const & xNode ); /// @return a helper class to manipulate effects inside the main sequence std::shared_ptr< sd::MainSequence > const & getMainSequence(); @@ -338,10 +338,10 @@ public: bool bEdit ) override; /** callback from the sd::View when a new paragraph for one object on this page is created */ - void onParagraphInserted( ::Outliner* pOutliner, Paragraph* pPara, SdrObject* pObj ); + void onParagraphInserted( ::Outliner* pOutliner, Paragraph const * pPara, SdrObject* pObj ); /** callback from the sd::View when a paragraph from one object on this page is removed */ - void onParagraphRemoving( ::Outliner* pOutliner, Paragraph* pPara, SdrObject* pObj ); + void onParagraphRemoving( ::Outliner* pOutliner, Paragraph const * pPara, SdrObject* pObj ); /** callback from the sd::View when an object just left text edit mode */ void onEndTextEdit( SdrObject* pObj ); diff --git a/sd/inc/stlpool.hxx b/sd/inc/stlpool.hxx index dd412963bd84..90041c847372 100644 --- a/sd/inc/stlpool.hxx +++ b/sd/inc/stlpool.hxx @@ -79,9 +79,9 @@ public: void CopyLayoutSheets(const OUString& rLayoutName, SdStyleSheetPool& rSourcePool, SdStyleSheetVector& rCreatedSheets ); void CopyGraphicSheets(SdStyleSheetPool& rSourcePool); void CopyCellSheets(SdStyleSheetPool& rSourcePool); - void CopyTableStyles(SdStyleSheetPool& rSourcePool); + void CopyTableStyles(SdStyleSheetPool const & rSourcePool); void CopyCellSheets(SdStyleSheetPool& rSourcePool, SdStyleSheetVector& rCreatedSheets); - void RenameAndCopyGraphicSheets(SdStyleSheetPool& rSourcePool, SdStyleSheetVector& rCreatedSheets, OUString &rRenameSuffix); + void RenameAndCopyGraphicSheets(SdStyleSheetPool& rSourcePool, SdStyleSheetVector& rCreatedSheets, OUString const &rRenameSuffix); void CreatePseudosIfNecessary(); void UpdateStdNames(); @@ -90,7 +90,7 @@ public: SdDrawDocument* GetDoc() const { return mpDoc; } - static SdStyleSheetVector CreateChildList( SdStyleSheet* pSheet ); + static SdStyleSheetVector CreateChildList( SdStyleSheet const * pSheet ); static void setDefaultOutlineNumberFormatBulletAndIndent(sal_uInt16 i, SvxNumberFormat &rNumberFormat); diff --git a/sd/inc/stlsheet.hxx b/sd/inc/stlsheet.hxx index 29e6f4a4698b..7d4e29b20466 100644 --- a/sd/inc/stlsheet.hxx +++ b/sd/inc/stlsheet.hxx @@ -78,7 +78,7 @@ public: //Broadcast that a SdStyleSheet has changed, taking into account outline sublevels //which need to be explicitly broadcast as changing if their parent style was //the one that changed - static void BroadcastSdStyleSheetChange(SfxStyleSheetBase* pStyleSheet, PresentationObjects ePO, + static void BroadcastSdStyleSheetChange(SfxStyleSheetBase const * pStyleSheet, PresentationObjects ePO, SfxStyleSheetBasePool* pSSPool); // XInterface diff --git a/sd/inc/textapi.hxx b/sd/inc/textapi.hxx index 02240acffcf2..32c89a9bbe30 100644 --- a/sd/inc/textapi.hxx +++ b/sd/inc/textapi.hxx @@ -46,7 +46,7 @@ public: void SAL_CALL dispose(); OutlinerParaObject* CreateText(); - void SetText( OutlinerParaObject& rText ); + void SetText( OutlinerParaObject const & rText ); OUString GetText(); static TextApiObject* getImplementation( const css::uno::Reference< css::text::XText >& ); -- cgit