From e2080e70fe8b085f18e868e46340454720fa94ca Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 18 Jun 2014 12:14:29 +0200 Subject: new compilerplugin returnbyref Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7 --- sd/source/ui/accessibility/AccessibleDocumentViewBase.cxx | 2 +- sd/source/ui/accessibility/AccessibleOutlineView.cxx | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'sd/source/ui/accessibility') diff --git a/sd/source/ui/accessibility/AccessibleDocumentViewBase.cxx b/sd/source/ui/accessibility/AccessibleDocumentViewBase.cxx index 0dba41cc3d5b..374cb96a1fd9 100644 --- a/sd/source/ui/accessibility/AccessibleDocumentViewBase.cxx +++ b/sd/source/ui/accessibility/AccessibleDocumentViewBase.cxx @@ -860,7 +860,7 @@ uno::Any SAL_CALL AccessibleDocumentViewBase::getExtendedAttributes() sValue += OUString::number((sal_Int16)((sal_uInt16)((pDrViewSh->getCurrentPage()->GetPageNum()-1)>>1) + 1)) ; sName = ";total-pages:"; sValue += sName; - sValue += OUString::number(pDrViewSh->GetPageTabControl()->GetPageCount()) ; + sValue += OUString::number(pDrViewSh->GetPageTabControl().GetPageCount()) ; sValue += ";"; if(pDrViewSh->IsLayerModeActive() && pDrViewSh->GetLayerTabControl()) // #i87182# { diff --git a/sd/source/ui/accessibility/AccessibleOutlineView.cxx b/sd/source/ui/accessibility/AccessibleOutlineView.cxx index dddaeec8a3dc..1ee2d591bc55 100644 --- a/sd/source/ui/accessibility/AccessibleOutlineView.cxx +++ b/sd/source/ui/accessibility/AccessibleOutlineView.cxx @@ -79,14 +79,14 @@ AccessibleOutlineView::AccessibleOutlineView ( { OutlinerView* pOutlineView = static_cast< ::sd::OutlineView*>( pView)->GetViewByWindow( pSdWindow ); - SdrOutliner* pOutliner = + SdrOutliner& rOutliner = static_cast< ::sd::OutlineView*>(pView)->GetOutliner(); - if( pOutlineView && pOutliner ) + if( pOutlineView ) { SAL_WNODEPRECATED_DECLARATIONS_PUSH maTextHelper.SetEditSource( ::std::auto_ptr< SvxEditSource >( new AccessibleOutlineEditSource( - *pOutliner, *pView, *pOutlineView, *pSdWindow ) ) ); + rOutliner, *pView, *pOutlineView, *pSdWindow ) ) ); SAL_WNODEPRECATED_DECLARATIONS_POP } } -- cgit