From e5dfdbcc2084bfdb213afbe03d00136e93d5c4d2 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 21 Jun 2018 15:34:16 +0200 Subject: loplugin:useuniqueptr in CustomAnimationDialog Change-Id: Ic2e93c1493159c9602bd68b409052117766dcc02 Reviewed-on: https://gerrit.libreoffice.org/56328 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sd/source/ui/animations/CustomAnimationDialog.cxx | 24 +++++++++++------------ 1 file changed, 11 insertions(+), 13 deletions(-) (limited to 'sd/source/ui/animations/CustomAnimationDialog.cxx') diff --git a/sd/source/ui/animations/CustomAnimationDialog.cxx b/sd/source/ui/animations/CustomAnimationDialog.cxx index 224bf1223bc1..fbcdad9097c9 100644 --- a/sd/source/ui/animations/CustomAnimationDialog.cxx +++ b/sd/source/ui/animations/CustomAnimationDialog.cxx @@ -2167,9 +2167,9 @@ CustomAnimationDialog::CustomAnimationDialog(vcl::Window* pParent, STLPropertySe sal_uInt16 nTimingId = mpTabControl->GetPageId("timing"); sal_uInt16 nTextAnimId = mpTabControl->GetPageId("textanim"); - mpEffectTabPage = VclPtr::Create( mpTabControl, mpSet ); + mpEffectTabPage = VclPtr::Create( mpTabControl, mpSet.get() ); mpTabControl->SetTabPage( nEffectId, mpEffectTabPage ); - mpDurationTabPage = VclPtr::Create( mpTabControl, mpSet ); + mpDurationTabPage = VclPtr::Create( mpTabControl, mpSet.get() ); mpTabControl->SetTabPage( nTimingId, mpDurationTabPage ); bool bHasText = false; @@ -2178,7 +2178,7 @@ CustomAnimationDialog::CustomAnimationDialog(vcl::Window* pParent, STLPropertySe if( bHasText ) { - mpTextAnimTabPage = VclPtr::Create( mpTabControl, mpSet ); + mpTextAnimTabPage = VclPtr::Create( mpTabControl, mpSet.get() ); mpTabControl->SetTabPage( nTextAnimId, mpTextAnimTabPage ); } else @@ -2202,8 +2202,8 @@ void CustomAnimationDialog::dispose() mpDurationTabPage.disposeAndClear(); mpTextAnimTabPage.disposeAndClear(); - delete mpSet; - delete mpResultSet; + mpSet.reset(); + mpResultSet.reset(); mpTabControl.clear(); TabDialog::dispose(); @@ -2211,23 +2211,21 @@ void CustomAnimationDialog::dispose() STLPropertySet* CustomAnimationDialog::getResultSet() { - delete mpResultSet; - mpResultSet = createDefaultSet(); - mpEffectTabPage->update( mpResultSet ); - mpDurationTabPage->update( mpResultSet ); + mpEffectTabPage->update( mpResultSet.get() ); + mpDurationTabPage->update( mpResultSet.get() ); if( mpTextAnimTabPage ) - mpTextAnimTabPage->update( mpResultSet ); + mpTextAnimTabPage->update( mpResultSet.get() ); - return mpResultSet; + return mpResultSet.get(); } -STLPropertySet* CustomAnimationDialog::createDefaultSet() +std::unique_ptr CustomAnimationDialog::createDefaultSet() { Any aEmpty; - STLPropertySet* pSet = new STLPropertySet(); + std::unique_ptr pSet(new STLPropertySet()); pSet->setPropertyDefaultValue( nHandleMaxParaDepth, makeAny( sal_Int32(-1) ) ); pSet->setPropertyDefaultValue( nHandleHasAfterEffect, makeAny( false ) ); -- cgit