From 3e1a46699e3b0868e2748f28e244b4d7de4fe775 Mon Sep 17 00:00:00 2001 From: Xisco Fauli Date: Fri, 29 Jan 2021 12:42:09 +0100 Subject: tdf#139996: do not crash if no slide is selected MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit when no slide is selected, SyncPageSelectionToDocument(xSelection).first returns SAL_MAX_UINT16, which is greater than 0 Change-Id: I20225dc3c89a34358949f991d1548e11803c3131 Change-Id: I787d46ff97a6a1401c5bc4ffc136aefc4bbeea29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110154 Tested-by: Jenkins Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara --- sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'sd') diff --git a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx index 05a571592ce3..25f3acafa9f0 100644 --- a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx +++ b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx @@ -797,6 +797,11 @@ void SlideSorterViewShell::ExecMovePageUp (SfxRequest& /*rReq*/) // SdDrawDocument MovePages is based on SdPage IsSelected, so // transfer the SlideSorter selection to SdPages sal_uInt16 firstSelectedPageNo = SyncPageSelectionToDocument(xSelection).first; + + // In case no slide is selected + if (firstSelectedPageNo == SAL_MAX_UINT16) + return; + // Now compute human page number from internal page number firstSelectedPageNo = (firstSelectedPageNo - 1) / 2; -- cgit