From b14224fe97b8a44232c9c1401d3a49771f46582e Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 2 Feb 2016 16:15:51 +0200 Subject: loplugin:unusedmethods using an idea from dtardon: noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- sd/inc/OutlinerIterator.hxx | 11 ----------- sd/source/ui/inc/unomodel.hxx | 1 - sd/source/ui/view/OutlinerIterator.cxx | 8 -------- 3 files changed, 20 deletions(-) (limited to 'sd') diff --git a/sd/inc/OutlinerIterator.hxx b/sd/inc/OutlinerIterator.hxx index 6d9b9189d0f2..f4392b056bdc 100644 --- a/sd/inc/OutlinerIterator.hxx +++ b/sd/inc/OutlinerIterator.hxx @@ -121,17 +121,6 @@ public: Returns a reference to this iterator pointing to the next object. */ Iterator& operator++ (); - /** The postfix increment operator returns the iterator still pointing - to the current object. Only the next call to - operator*() will return the next object. When in - doubt rather use the prefix increment operator. - @param dummy - A dummy operator used by the compiler. - @return - Returns a copy of the iterator as it where before the operator - was called. - */ - Iterator operator++ (int); /** Test equality of two iterators. Two iterators are taken to be equal when they point are of the same type (their implementation objects are instances of the same class) and point to the same object. diff --git a/sd/source/ui/inc/unomodel.hxx b/sd/source/ui/inc/unomodel.hxx index fe09a745845f..af9b3372080f 100644 --- a/sd/source/ui/inc/unomodel.hxx +++ b/sd/source/ui/inc/unomodel.hxx @@ -138,7 +138,6 @@ public: static rtl::Reference< SdXImpressDocument > GetModel( SdDrawDocument* pDoc ); // intern - bool operator==( const SdXImpressDocument& rModel ) const { return mpDoc == rModel.mpDoc; } bool operator!=( const SdXImpressDocument& rModel ) const { return mpDoc != rModel.mpDoc; } ::sd::DrawDocShell* GetDocShell() const { return mpDocShell; } diff --git a/sd/source/ui/view/OutlinerIterator.cxx b/sd/source/ui/view/OutlinerIterator.cxx index 61f8ddd802bc..8a2188b46673 100644 --- a/sd/source/ui/view/OutlinerIterator.cxx +++ b/sd/source/ui/view/OutlinerIterator.cxx @@ -124,14 +124,6 @@ Iterator& Iterator::operator++ () return *this; } -Iterator Iterator::operator++ (int) -{ - Iterator aTmp (*this); - if (mpIterator!=nullptr) - mpIterator->GotoNextText(); - return aTmp; -} - bool Iterator::operator== (const Iterator& rIterator) { if (mpIterator == nullptr || rIterator.mpIterator==nullptr) -- cgit