From f0aef9b31f91d5aba71b6879ad13e39241aa4f0f Mon Sep 17 00:00:00 2001
From: Caolán McNamara <caolanm@redhat.com>
Date: Tue, 3 Feb 2015 11:37:18 +0000
Subject: valgrind: fix leak

==1739==    by 0x7A93F1C: SfxUInt16Item::Clone(SfxItemPool*) const (in core/instdir/program/libsvllo.so)
==1739==    by 0x7047E11: SfxShell::PutItem(SfxPoolItem const&) (shell.cxx:196)
==1739==    by 0x27FCA298: SdModule::GetSdOptions(DocumentType) (sdmod.cxx:172)

none of the other uses of pCache->SetState clone, and I don't see why this one
does.

Change-Id: I7d3cf6969c433c890776dfbcc1dc57d72420b6e2
---
 sd/source/ui/app/sdmod.cxx | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'sd')

diff --git a/sd/source/ui/app/sdmod.cxx b/sd/source/ui/app/sdmod.cxx
index 909213a6939d..8f0f06cda1eb 100644
--- a/sd/source/ui/app/sdmod.cxx
+++ b/sd/source/ui/app/sdmod.cxx
@@ -103,9 +103,7 @@ SdModule::SdModule(SfxObjectFactory* pFact1, SfxObjectFactory* pFact2 )
 SdModule::~SdModule()
 {
     delete pSearchItem;
-
-    if( pNumberFormatter )
-        delete pNumberFormatter;
+    delete pNumberFormatter;
 
     ::sd::DrawDocShell* pDocShell = PTR_CAST(::sd::DrawDocShell, SfxObjectShell::Current());
     if( pDocShell )
-- 
cgit