From f1f33b332a0b4ada8ac8ff885fc2efee768091a6 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Tue, 6 Oct 2020 11:23:35 +0100 Subject: move set_user_managed_scrolling to an initial weld argument MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara --- sd/source/filter/html/pubdlg.cxx | 2 +- sd/source/ui/animations/SlideTransitionPane.cxx | 2 +- sd/source/ui/dlg/sdpreslt.cxx | 2 +- sd/source/ui/table/TableDesignPane.cxx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'sd') diff --git a/sd/source/filter/html/pubdlg.cxx b/sd/source/filter/html/pubdlg.cxx index 0855240aac7d..6a9f2fd29aaf 100644 --- a/sd/source/filter/html/pubdlg.cxx +++ b/sd/source/filter/html/pubdlg.cxx @@ -610,7 +610,7 @@ void SdPublishingDlg::CreatePages() m_xPage5 = m_xBuilder->weld_container("page5"); m_xPage5_Title = m_xBuilder->weld_label("buttonStyleLabel"); m_xPage5_TextOnly = m_xBuilder->weld_check_button("textOnlyCheckbutton"); - m_xPage5_Buttons.reset(new ValueSet(m_xBuilder->weld_scrolled_window("buttonsDrawingareawin"))); + m_xPage5_Buttons.reset(new ValueSet(m_xBuilder->weld_scrolled_window("buttonsDrawingareawin", true))); m_xPage5_ButtonsWnd.reset(new weld::CustomWeld(*m_xBuilder, "buttonsDrawingarea", *m_xPage5_Buttons)); aAssistentFunc.InsertControl(5, m_xPage5.get()); aAssistentFunc.InsertControl(5, m_xPage5_Title.get()); diff --git a/sd/source/ui/animations/SlideTransitionPane.cxx b/sd/source/ui/animations/SlideTransitionPane.cxx index 8c9ad5bdb8ed..a796b6511ce7 100644 --- a/sd/source/ui/animations/SlideTransitionPane.cxx +++ b/sd/source/ui/animations/SlideTransitionPane.cxx @@ -431,7 +431,7 @@ void SlideTransitionPane::Initialize(SdDrawDocument* pDoc) mxCBX_duration->get_widget().set_size_request(aOptimalSize.Width(), -1); rSpinButton.set_max(nMax); - mxVS_TRANSITION_ICONS.reset(new TransitionPane(m_xBuilder->weld_scrolled_window("transitions_iconswin"))); + mxVS_TRANSITION_ICONS.reset(new TransitionPane(m_xBuilder->weld_scrolled_window("transitions_iconswin", true))); mxVS_TRANSITION_ICONSWin.reset(new weld::CustomWeld(*m_xBuilder, "transitions_icons", *mxVS_TRANSITION_ICONS)); if( pDoc ) diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx index 6593251299a7..6cc2ec279f28 100644 --- a/sd/source/ui/dlg/sdpreslt.cxx +++ b/sd/source/ui/dlg/sdpreslt.cxx @@ -45,7 +45,7 @@ SdPresLayoutDlg::SdPresLayoutDlg(::sd::DrawDocShell* pDocShell, , m_xCbxMasterPage(m_xBuilder->weld_check_button("masterpage")) , m_xCbxCheckMasters(m_xBuilder->weld_check_button("checkmasters")) , m_xBtnLoad(m_xBuilder->weld_button("load")) - , m_xVS(new ValueSet(m_xBuilder->weld_scrolled_window("selectwin"))) + , m_xVS(new ValueSet(m_xBuilder->weld_scrolled_window("selectwin", true))) , m_xVSWin(new weld::CustomWeld(*m_xBuilder, "select", *m_xVS)) { m_xVSWin->set_size_request(m_xBtnLoad->get_approximate_digit_width() * 60, diff --git a/sd/source/ui/table/TableDesignPane.cxx b/sd/source/ui/table/TableDesignPane.cxx index 8ff07499c0eb..0680c268d3b4 100644 --- a/sd/source/ui/table/TableDesignPane.cxx +++ b/sd/source/ui/table/TableDesignPane.cxx @@ -90,7 +90,7 @@ const std::string_view gPropNames[CB_COUNT] = TableDesignWidget::TableDesignWidget(weld::Builder& rBuilder, ViewShellBase& rBase) : mrBase(rBase) - , m_xValueSet(new TableValueSet(rBuilder.weld_scrolled_window("previewswin"))) + , m_xValueSet(new TableValueSet(rBuilder.weld_scrolled_window("previewswin", true))) , m_xValueSetWin(new weld::CustomWeld(rBuilder, "previews", *m_xValueSet)) { m_xValueSet->SetStyle(m_xValueSet->GetStyle() | WB_NO_DIRECTSELECT | WB_FLATVALUESET | WB_ITEMBORDER); -- cgit