From 00dfa1f2f06bcba5dcd67e8955f9a78b95f16632 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Mon, 22 Jul 2019 12:15:28 +0100 Subject: cid#1448446 Unchecked dynamic_cast MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I888ca249e0e9551c74611dcfb8ba7c7c1dc36880 Reviewed-on: https://gerrit.libreoffice.org/76133 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- sdext/source/pdfimport/tree/writertreevisiting.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sdext') diff --git a/sdext/source/pdfimport/tree/writertreevisiting.cxx b/sdext/source/pdfimport/tree/writertreevisiting.cxx index 6c0325019c9a..b84e5f2fcb07 100644 --- a/sdext/source/pdfimport/tree/writertreevisiting.cxx +++ b/sdext/source/pdfimport/tree/writertreevisiting.cxx @@ -694,8 +694,8 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement& rElem ) if (rit == rElem.Children.rend()) return; - ParagraphElement* pPara = dynamic_cast(rit->get()); - if( !(pPara->y > rElem.h*0.85 && pPara->isSingleLined( m_rProcessor )) ) + ParagraphElement& rPara = dynamic_cast(*rit->get()); + if( !(rPara.y > rElem.h*0.85 && rPara.isSingleLined( m_rProcessor )) ) return; std::list< std::unique_ptr >::reverse_iterator next_it = rit; @@ -704,10 +704,10 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement& rElem ) { pNextPara = dynamic_cast(next_it->get()); } - if( pNextPara && pNextPara->y < pPara->y-pPara->h*2 ) + if( pNextPara && pNextPara->y < rPara.y-rPara.h*2 ) { rElem.FooterElement = std::move(*rit); - pPara->Parent = nullptr; + rPara.Parent = nullptr; rElem.Children.erase( std::next(rit).base() ); } } -- cgit