From be8c414567f49242164b1fdfb12764b16be355c1 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri, 19 Jan 2018 09:13:03 +0200
Subject: loplugin:unusedmethods also check for functions returning bool

we were previously excluding them

Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 sdext/source/minimizer/impoptimizer.cxx           | 3 +--
 sdext/source/minimizer/impoptimizer.hxx           | 2 +-
 sdext/source/presenter/PresenterWindowManager.cxx | 4 +---
 sdext/source/presenter/PresenterWindowManager.hxx | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

(limited to 'sdext')

diff --git a/sdext/source/minimizer/impoptimizer.cxx b/sdext/source/minimizer/impoptimizer.cxx
index ccbd4cc1f056..2507a657abbb 100644
--- a/sdext/source/minimizer/impoptimizer.cxx
+++ b/sdext/source/minimizer/impoptimizer.cxx
@@ -509,7 +509,7 @@ void ImpOptimizer::DispatchStatus()
 }
 
 
-bool ImpOptimizer::Optimize()
+void ImpOptimizer::Optimize()
 {
 
     if ( !maCustomShowName.isEmpty() )
@@ -559,7 +559,6 @@ bool ImpOptimizer::Optimize()
     }
     SetStatusValue( TK_Progress, Any( static_cast< sal_Int32 >( 100 ) ) );
     DispatchStatus();
-    return true;
 }
 
 static void DispatchURL( const Reference< XComponentContext >& xContext, const OUString& sURL, const Reference< XFrame >& xFrame )
diff --git a/sdext/source/minimizer/impoptimizer.hxx b/sdext/source/minimizer/impoptimizer.hxx
index 60f15fb500ae..169c3fdfb834 100644
--- a/sdext/source/minimizer/impoptimizer.hxx
+++ b/sdext/source/minimizer/impoptimizer.hxx
@@ -56,7 +56,7 @@ private:
 
     css::uno::Reference< css::frame::XFrame > mxInformationDialog;
 
-    bool Optimize();
+    void Optimize();
 
 public:
 
diff --git a/sdext/source/presenter/PresenterWindowManager.cxx b/sdext/source/presenter/PresenterWindowManager.cxx
index 99b71da4dd26..5c206493768a 100644
--- a/sdext/source/presenter/PresenterWindowManager.cxx
+++ b/sdext/source/presenter/PresenterWindowManager.cxx
@@ -318,7 +318,7 @@ void SAL_CALL PresenterWindowManager::disposing (const lang::EventObject& rEvent
 }
 
 
-bool PresenterWindowManager::PaintChildren (const awt::PaintEvent& rEvent) const
+void PresenterWindowManager::PaintChildren (const awt::PaintEvent& rEvent) const
 {
     // Call windowPaint on all children that lie in or touch the
     // update rectangle.
@@ -368,8 +368,6 @@ bool PresenterWindowManager::PaintChildren (const awt::PaintEvent& rEvent) const
             OSL_FAIL("paint children failed!");
         }
     }
-
-    return false;
 }
 
 void PresenterWindowManager::SetLayoutMode (const LayoutMode eMode)
diff --git a/sdext/source/presenter/PresenterWindowManager.hxx b/sdext/source/presenter/PresenterWindowManager.hxx
index 64d850386f35..bb765094869f 100644
--- a/sdext/source/presenter/PresenterWindowManager.hxx
+++ b/sdext/source/presenter/PresenterWindowManager.hxx
@@ -173,7 +173,7 @@ private:
     LayoutListenerContainer maLayoutListeners;
     bool mbIsMouseClickPending;
 
-    bool PaintChildren (const css::awt::PaintEvent& rEvent) const;
+    void PaintChildren (const css::awt::PaintEvent& rEvent) const;
     void UpdateWindowSize (const css::uno::Reference<css::awt::XWindow>& rxBorderWindow);
     void PaintBackground (const css::awt::Rectangle& rUpdateBox);
     void ProvideBackgroundBitmap();
-- 
cgit